Skip to content

[quant] QNNPACK Add deconvolution parameters#36716

Closed
z-a-f wants to merge 16 commits intogh/z-a-f/15/basefrom
gh/z-a-f/15/head
Closed

[quant] QNNPACK Add deconvolution parameters#36716
z-a-f wants to merge 16 commits intogh/z-a-f/15/basefrom
gh/z-a-f/15/head

Conversation

@z-a-f
Copy link
Copy Markdown

@z-a-f z-a-f commented Apr 16, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21110112

z-a-f pushed a commit that referenced this pull request Apr 16, 2020
[quant] Refactor QNNPACK conv for deconv
c2dc5c4 
ghstack-source-id: c08a01d
Pull Request resolved: #36716
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 16, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit 9f5e65a (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 49 times.

z-a-f pushed a commit that referenced this pull request Apr 16, 2020
[quant] Refactor QNNPACK conv for deconv
c9f0863 
ghstack-source-id: 744e507
Pull Request resolved: #36716
z-a-f pushed a commit that referenced this pull request Apr 17, 2020
[quant] Refactor QNNPACK conv for deconv
7b03f87 
ghstack-source-id: 613bd03
Pull Request resolved: #36716
@z-a-f z-a-f mentioned this pull request Apr 17, 2020
Closed
supriyar
supriyar reviewed Apr 17, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/src/deconv-run.cc Outdated
kimishpatel
kimishpatel reviewed Apr 17, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h Outdated
@z-a-f z-a-f requested review from kimishpatel and supriyar April 18, 2020 07:25
supriyar
supriyar reviewed Apr 23, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/qnnpack_func.h Outdated
supriyar
supriyar reviewed Apr 23, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h Outdated
kimishpatel
kimishpatel reviewed Apr 24, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h Outdated
kimishpatel
kimishpatel reviewed Apr 24, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h
kimishpatel
kimishpatel reviewed Apr 24, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h Outdated
kimishpatel
kimishpatel reviewed Apr 24, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qnnpack/include/conv_utils.h Outdated
@z-a-f z-a-f mentioned this pull request Apr 28, 2020
Closed
@z-a-f z-a-f changed the title [quant] Refactor QNNPACK conv for deconv [quant] QNNPACK Add deconvolution parameters Apr 28, 2020
@z-a-f z-a-f mentioned this pull request Apr 29, 2020
Closed
@z-a-f z-a-f requested review from kimishpatel and supriyar April 29, 2020 11:24
supriyar
supriyar approved these changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@supriyar supriyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 1, 2020

@z-a-f merged this pull request in e841bea.

@facebook-github-bot facebook-github-bot deleted the gh/z-a-f/15/head branch May 4, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[quant] QNNPACK Add deconvolution parameters (pytorch#36716)
3257c81 
Summary: Pull Request resolved: pytorch#36716

Test Plan: Imported from OSS

Differential Revision: D21110112

Pulled By: z-a-f

fbshipit-source-id: 4b62e1bb3c3b6a3276bc5f8ee5ead0f513ec0137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supriyar supriyar supriyar approved these changes

@raghuramank100 raghuramank100 Awaiting requested review from raghuramank100

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@z-a-f @facebook-github-bot @supriyar @kimishpatel @mruberry