Add a test to verify non-contiguous tensors work correctly with RPC.#36705
Closed
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/119/basefrom
Closed
Add a test to verify non-contiguous tensors work correctly with RPC.#36705pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/119/basefrom
pritamdamania87 wants to merge 1 commit intogh/pritamdamania87/119/basefrom
Conversation
Differential Revision: [D21058176](https://our.internmc.facebook.com/intern/diff/D21058176/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Apr 16, 2020
Differential Revision: [D21058176](https://our.internmc.facebook.com/intern/diff/D21058176/) ghstack-source-id: 102257937 Pull Request resolved: #36705
💊 Build failures summary and remediationsAs of commit 46cd21f (more details on the Dr. CI page):
Extra GitHub checks
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
mrshenli
reviewed
Apr 16, 2020
|
|
||
| # Send non-cont tensor over RPC. | ||
| next_rank = (self.rank + 1) % self.world_size | ||
| t_ret = rpc.rpc_sync(worker_name(next_rank), non_cont_test, args=(t_view, t_cont)) |
Contributor
There was a problem hiding this comment.
Isn't this behavior depending on the sparsity of the data?
pytorch/torch/csrc/distributed/rpc/utils.cpp
Line 236 in 9e016f7
Contributor
Author
There was a problem hiding this comment.
Yes, although given the small size of the tensor here I don't think that we're copying the tensor. This test was mostly to ensure we can send non-contiguous tensors over the wire without any correctness issues.
mrshenli
approved these changes
Apr 17, 2020
Contributor
|
This pull request has been merged in b0227f2. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#36705) Summary: Pull Request resolved: pytorch#36705 ghstack-source-id: 102257937 Test Plan: waitforbuildbot Differential Revision: D21058176 fbshipit-source-id: 1d32730d61420324856cc641f888751418c1dd26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21058176