Skip to content

Fix hardsigmoid/hardswish for proper device dispatch.#36704

Closed
ailzhang wants to merge 1 commit intopytorch:masterfrom
ailzhang:fix_hardsigmoid
Closed

Fix hardsigmoid/hardswish for proper device dispatch.#36704
ailzhang wants to merge 1 commit intopytorch:masterfrom
ailzhang:fix_hardsigmoid

Conversation

@ailzhang
Copy link
Copy Markdown
Contributor

#36351 make hardsigmoid_backward use tensoriterator but that can be done only after proper device dispatch.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 16, 2020

💊 Build failures summary and remediations

As of commit dc0db16 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

@ailzhang ailzhang requested a review from gchanan April 16, 2020 15:44
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ailzhang ailzhang requested a review from vkuzo April 16, 2020 22:53
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ailzhang merged this pull request in adca88e.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
pytorch#36351 make `hardsigmoid_backward` use tensoriterator but that can be done only after proper device dispatch.
Pull Request resolved: pytorch#36704

Differential Revision: D21068126

Pulled By: ailzhang

fbshipit-source-id: 6a6a74216f2b50fa7d15f692cd1583d3d233580a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants