[jit] Add dictionary as output of tracer#36696
Closed
wanchaol wants to merge 3 commits intogh/wanchaol/99/basefrom
Closed
[jit] Add dictionary as output of tracer#36696wanchaol wants to merge 3 commits intogh/wanchaol/99/basefrom
wanchaol wants to merge 3 commits intogh/wanchaol/99/basefrom
Conversation
This PR add dictionary as a supported output of tracer under the strict flag. [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 2aaf04e (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 9 times. |
jamesr66a
approved these changes
Apr 16, 2020
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Great, thanks for hanging in there as we resolved the ordering issues. I'm glad we were able to solve a hidden bug in TorchScript as a side effect of this
This PR add dictionary as a supported output of tracer under the strict flag. Differential Revision: [D21056962](https://our.internmc.facebook.com/intern/diff/D21056962) [ghstack-poisoned]
This PR add dictionary as a supported output of tracer under the strict flag. Differential Revision: [D21056962](https://our.internmc.facebook.com/intern/diff/D21056962) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36696 This PR add dictionary as a supported output of tracer under the strict flag. Test Plan: Imported from OSS Reviewed By: houseroad Differential Revision: D21056962 Pulled By: wanchaol fbshipit-source-id: ace498182d636de853cf8a1efb3dc77f5d53db29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR add dictionary as a supported output of tracer under the strict
flag.
Differential Revision: D21056962