quantized layer norm: add to static quant#36690
Closed
vkuzo wants to merge 3 commits intogh/vkuzo/35/basefrom
Closed
quantized layer norm: add to static quant#36690vkuzo wants to merge 3 commits intogh/vkuzo/35/basefrom
vkuzo wants to merge 3 commits intogh/vkuzo/35/basefrom
Conversation
Summary: Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit f3af14b (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
Summary: Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Apr 15, 2020
Summary: Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5370ccb Pull Request resolved: #36690
Summary: Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21055401](https://our.internmc.facebook.com/intern/diff/D21055401) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Apr 16, 2020
Summary: Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4a7194e Pull Request resolved: #36690
|
|
||
| checkQuantized(model) | ||
|
|
||
| def test_normalization(self): |
Contributor
There was a problem hiding this comment.
This test (and other tests here) only test for FBGEMM, needs to be fixed in a later PR.
| self.assertEqual(quant_ref.int_repr().numpy(), qy.int_repr().numpy(), | ||
| message="BatchNorm3d module API failed") | ||
|
|
||
| def test_layer_norm(self): |
Contributor
There was a problem hiding this comment.
Can we test this over qnnpack and FBGEMM? Qnnpack only tests the x86 path.
@given(qengine=st.sampled_from(("qnnpack", "fbgemm")))and using qengine as an argument to the test should do it.
Contributor
Author
There was a problem hiding this comment.
we don't have a mobile implementation for LayerNorm. It might run correctly on mobile but it would be too slow to be useful. Should we still test for it? I'm flexible, more just curios on how we've done it in the past.
raghuramank100
approved these changes
Apr 16, 2020
Contributor
raghuramank100
left a comment
There was a problem hiding this comment.
Requesting extending test to qnnpack, looks good otherwise!
Contributor
|
This pull request has been merged in 2c558db. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36690 Adds the static quantization hook for LayerNorm Test Plan: ``` python test/quantization/test_quantized_nn_mods.py ModuleAPITest.test_layer_norm python test/quantization/test_quantization.py EagerModePostTrainingQuantTest.test_normalization ``` Imported from OSS Differential Revision: D21055401 fbshipit-source-id: 188329f35359576d50ed0db5fb675ce68c28bf7d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds the static quantization hook for LayerNorm
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21055401