[quant][graph] Graph mode quantization support for sigmoid#36622
Closed
supriyar wants to merge 6 commits intogh/supriyar/87/basefrom
Closed
[quant][graph] Graph mode quantization support for sigmoid#36622supriyar wants to merge 6 commits intogh/supriyar/87/basefrom
supriyar wants to merge 6 commits intogh/supriyar/87/basefrom
Conversation
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 14, 2020
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
approved these changes
Apr 15, 2020
jerryzh168
reviewed
Apr 15, 2020
| x = torch.max(x) | ||
| x = torch.min(x) | ||
| x = torch.mean(x) | ||
| x = torch.sigmoid(x) |
Contributor
There was a problem hiding this comment.
looks like we have sigmoid module as well: https://pytorch.org/docs/stable/nn.html?highlight=sigmoid#torch.nn.Sigmoid
could you add a test for that?
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 15, 2020
💊 Build failures summary and remediationsAs of commit b05127e (more details on the Dr. CI page):
Extra GitHub checks
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
jerryzh168
approved these changes
Apr 15, 2020
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 753157b. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…6622) Summary: Pull Request resolved: pytorch#36622 Test Plan: python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops Imported from OSS Differential Revision: D21075255 fbshipit-source-id: 025f432215eaa8acf34d492e7722102ca053abeb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/quantization/test_quantize_script.py test_swap_dequantize_all_ops
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21075255