[caffe2] Add support for std::shared_ptr<std::vector<TensorList>> in PackRecordsOp and UnPackRecordsOp#36550
Closed
hlu1 wants to merge 2 commits intopytorch:masterfrom
Closed
[caffe2] Add support for std::shared_ptr<std::vector<TensorList>> in PackRecordsOp and UnPackRecordsOp#36550hlu1 wants to merge 2 commits intopytorch:masterfrom
hlu1 wants to merge 2 commits intopytorch:masterfrom
Conversation
Differential Revision: D20985924 fbshipit-source-id: f69279c2596a09a1c28c19ce37efd9b0ec0e0010
…PackRecordsOp and UnPackRecordsOp Summary: Separate dataset_ops changes into a separate diff. Test Plan: ``` buck test caffe2/caffe2/python/operator_test:dataset_ops_test ``` AI/AF canary (tested with D20959214): https://our.intern.facebook.com/intern/experiment_store/experiment/3298538636995/#commit1-commit2 https://our.intern.facebook.com/intern/experiment_store/experiment/2199027015376/#commit1-commit2 Reviewed By: yinghai Differential Revision: D20988910 fbshipit-source-id: ce748383f95259eeee59be289665f243c2adc7bb
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20988910 |
💊 Build failures summary and remediationsAs of commit 2f8d955 (more details on the Dr. CI page):
🚧 1 upstream failure:These were probably caused by upstream breakages:
Extra GitHub checks
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 3 times. |
Contributor
|
This pull request has been merged in fb70b4f. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…PackRecordsOp and UnPackRecordsOp (pytorch#36550) Summary: Pull Request resolved: pytorch#36550 Separate dataset_ops changes into a separate diff. Test Plan: ``` buck test caffe2/caffe2/python/operator_test:dataset_ops_test ``` AI/AF canary (tested with D20959214): https://our.intern.facebook.com/intern/experiment_store/experiment/3298538636995/#commit1-commit2 https://our.intern.facebook.com/intern/experiment_store/experiment/2199027015376/#commit1-commit2 Reviewed By: yinghai Differential Revision: D20988910 fbshipit-source-id: b37a7bfd131813e9472a5e2fa24d681d1ef19018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Separate dataset_ops changes into a separate diff.
Test Plan:
AI/AF canary (tested with D20959214):
https://our.intern.facebook.com/intern/experiment_store/experiment/3298538636995/#commit1-commit2
https://our.intern.facebook.com/intern/experiment_store/experiment/2199027015376/#commit1-commit2
Reviewed By: yinghai
Differential Revision: D20988910