Skip to content

[TensorExpr] Postpone insertion of Alloc/Free statements in computeAt.#36526

Closed
ZolotukhinM wants to merge 5 commits intogh/ZolotukhinM/223/basefrom
gh/ZolotukhinM/223/head
Closed

[TensorExpr] Postpone insertion of Alloc/Free statements in computeAt.#36526
ZolotukhinM wants to merge 5 commits intogh/ZolotukhinM/223/basefrom
gh/ZolotukhinM/223/head

Conversation

@ZolotukhinM
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM commented Apr 13, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21004740

@ZolotukhinM ZolotukhinM requested a review from apaszke as a code owner April 13, 2020 22:25
ZolotukhinM pushed a commit that referenced this pull request Apr 13, 2020
[TensorExpr] Postpone insertion of Alloc/Free statements in computeAt.
98cf522 
ghstack-source-id: dc85a73
Pull Request resolved: #36526
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 13, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 13, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit c208ce0 (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR

    • 1/2 non-CircleCI failure(s)

  • 1/2 broken upstream at merge base b38d505 on Apr 13 from 4:26pm to 7:02pm PDT (10 commits; c9a1fc2 - 455d4aa)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

Extra GitHub checks

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 15 times.

@ZolotukhinM ZolotukhinM requested review from bwasti and zheng-xq April 13, 2020 23:15
bwasti
bwasti approved these changes Apr 13, 2020
View reviewed changes
Comment thread torch/csrc/jit/tensorexpr/loopnest.cpp Outdated

// Mark the new temp buffer as requiring an alloc (it will be inserted as a
// part of prepareForCodegen.
temp_bufs_.push_back(temp_buf);
Copy link
Copy Markdown
Contributor

@bwasti bwasti Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we have this is as a single data structure? std::vector<std::pair<..>>

Comment thread torch/csrc/jit/tensorexpr/loopnest.cpp Outdated
}

// Mark the new temp buffer as requiring an alloc (it will be inserted as a
// part of prepareForCodegen.
Copy link
Copy Markdown
Contributor

@bwasti bwasti Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might make sense to move the bounds inference to prepareforcodegen

Copy link
Copy Markdown
Author

@ZolotukhinM ZolotukhinM Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what we should be ultimately doing.

ZolotukhinM pushed a commit that referenced this pull request Apr 14, 2020
[TensorExpr] Postpone insertion of Alloc/Free statements in computeAt.
95a1d85 
ghstack-source-id: a3f54d7
Pull Request resolved: #36526
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 14, 2020

@ZolotukhinM merged this pull request in d5ba39c.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/223/head branch April 17, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[TensorExpr] Postpone insertion of Alloc/Free statements in computeAt. (
933096d 
pytorch#36526)

Summary: Pull Request resolved: pytorch#36526

Test Plan: Imported from OSS

Differential Revision: D21004740

Pulled By: ZolotukhinM

fbshipit-source-id: 8ac8db0d4e31065e4fbd3e0cc27f15a15dcb141c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwasti bwasti bwasti approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@zheng-xq zheng-xq Awaiting requested review from zheng-xq

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZolotukhinM @facebook-github-bot @bwasti @mruberry