[quant] Update qbatch_norm name to qbatch_norm2d#36494
Closed
supriyar wants to merge 4 commits intogh/supriyar/82/basefrom
Closed
[quant] Update qbatch_norm name to qbatch_norm2d#36494supriyar wants to merge 4 commits intogh/supriyar/82/basefrom
supriyar wants to merge 4 commits intogh/supriyar/82/basefrom
Conversation
Summary: Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 3a593cf (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 16 times. |
Summary: Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
reviewed
Apr 13, 2020
|
|
||
| static auto registry = torch::RegisterOperators().op( | ||
| "quantized::batch_norm(Tensor qx, " | ||
| "quantized::batch_norm2d(Tensor qx, " |
Contributor
There was a problem hiding this comment.
do you need to keep quantized::batch_norm for BC?
Contributor
Author
There was a problem hiding this comment.
I don't think so. The aten::quantized_batch_norm is still preserving bc.
cc @lly-zero-one for new op signature.
Contributor
There was a problem hiding this comment.
Can you also change the convert script?
Contributor
There was a problem hiding this comment.
NVM, I think I just need to update the model.
jerryzh168
approved these changes
Apr 13, 2020
Summary: Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 14, 2020
Summary: Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21008831](https://our.internmc.facebook.com/intern/diff/D21008831) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 4ebb127. |
karansachdev-1012
pushed a commit
to karansachdev-1012/pytorch
that referenced
this pull request
Feb 17, 2026
Summary: Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 3ff0bf7 Pull Request resolved: pytorch/pytorch#36494
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36494 Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops Test Plan: python test/quantization/test_quantized.py test_batch_norm2d Imported from OSS Differential Revision: D21008831 fbshipit-source-id: f81ca71a331d5620fd6a3f6175020a30f2e2566b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Make name consistent with op. Since we have batch_norm2d and batch_norm3d ops
Test Plan:
python test/quantization/test_quantized.py test_batch_norm2d
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21008831