Make trivial thread-idx for degenerate statements without thread-idx.#36480
Closed
zheng-xq wants to merge 5 commits intogh/zheng-xq/3/basefrom
Closed
Make trivial thread-idx for degenerate statements without thread-idx.#36480zheng-xq wants to merge 5 commits intogh/zheng-xq/3/basefrom
zheng-xq wants to merge 5 commits intogh/zheng-xq/3/basefrom
Conversation
[ghstack-poisoned]
This was referenced Apr 13, 2020
💊 Build failures summary and remediationsAs of commit 77dee3f (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 15 times. |
…thread-idx." Differential Revision: [D20992505](https://our.internmc.facebook.com/intern/diff/D20992505) [ghstack-poisoned]
…thread-idx." Differential Revision: [D20992505](https://our.internmc.facebook.com/intern/diff/D20992505) [ghstack-poisoned]
ZolotukhinM
approved these changes
Apr 15, 2020
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good overall, some comments are inline!
| } | ||
|
|
||
| // Find all the statements that are not covered by any thread-idx axes, | ||
| // and wrapp them under a trivial thread idx. |
| std::list<Stmt*> old_stmts = v->stmts(); | ||
| std::vector<bool> need_rewrites(old_stmts.size()); | ||
| std::vector<Stmt*> new_stmts(old_stmts.size()); | ||
| ; |
|
|
||
| start = stop; | ||
| } | ||
| Stmt* rewritten_block = Block::make(rewrite_stmts); |
There was a problem hiding this comment.
Maybe add an assert that rewrite_stmts.size() == new_stmts.size() == old_stmts.size()?
nickgg
reviewed
Apr 15, 2020
| b_ref(i) = i; | ||
| } | ||
|
|
||
| float* a_dev = nullptr; |
Contributor
There was a problem hiding this comment.
Running the codegen is not sufficient here, I think. Can you verify the correct code was generated in a literal way?
Contributor
Author
There was a problem hiding this comment.
Added a TODO to add the check in a follow-up.
…thread-idx." Differential Revision: [D20992505](https://our.internmc.facebook.com/intern/diff/D20992505) [ghstack-poisoned]
…thread-idx." Differential Revision: [D20992505](https://our.internmc.facebook.com/intern/diff/D20992505) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…pytorch#36480) Summary: Pull Request resolved: pytorch#36480 Test Plan: Imported from OSS Differential Revision: D20992505 Pulled By: zheng-xq fbshipit-source-id: 3d4e5401b59b9507b5f2db659e511bd1af53f5ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D20992505