[caffe2] Enable copying for caffe2::Tensor#36468
Closed
hlu1 wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Summary: Since `caffe2::Tensor` is now refcounted, enabling copy constructor and the copy assignment operator should be fine. Test Plan: ``` buck test mode/dev //caffe2/caffe2:caffe2_test_cpu -- TensorTest ``` Differential Revision: D20985924 fbshipit-source-id: b73939b84f1aa255eac8a8ff1a9fe8ff8cc39887
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20985924 |
💊 Build failures summary and remediationsAs of commit 09ce495 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
|
This pull request has been merged in 4d1ccaf. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36468 Since `caffe2::Tensor` is now refcounted, enabling copy constructor and the copy assignment operator should be fine. Test Plan: ``` buck test mode/dev //caffe2/caffe2:caffe2_test_cpu -- TensorTest ``` AI/AF canaries with changes up to D20959214: https://our.intern.facebook.com/intern/experiment_store/experiment/3298538636995/#commit1-commit2 https://our.intern.facebook.com/intern/experiment_store/experiment/2199027015376/#commit1-commit2 AI/AF canaries on this diff: https://our.intern.facebook.com/intern/ads/canary/425960191574068914/ https://our.intern.facebook.com/intern/ads/canary/425960179835413033/ Reviewed By: yinghai Differential Revision: D20985924 fbshipit-source-id: ead5f5ceff23d0adc06d598128de16a5533d767b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Since
caffe2::Tensoris now refcounted, enabling copy constructor and the copy assignment operator should be fine.Test Plan:
Differential Revision: D20985924