Skip to content

Use unittest assertWarns instead#36411

Closed
wanchaol wants to merge 3 commits intogh/wanchaol/96/basefrom
gh/wanchaol/96/head
Closed

Use unittest assertWarns instead#36411
wanchaol wants to merge 3 commits intogh/wanchaol/96/basefrom
gh/wanchaol/96/head

Conversation

@wanchaol
Copy link
Copy Markdown
Collaborator

@wanchaol wanchaol commented Apr 10, 2020

Stack from ghstack:

This PR remove pytorch specific defined assertwarns and use the unit
test one, also format some tests

Differential Revision: D20998159

This PR remove pytorch specific defined assertwarns and use the unit
test one, also format some tests

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 10, 2020

💊 Build failures summary and remediations

As of commit c71f896 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 10 times.

Copy link
Copy Markdown
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping for data_parallel related changes.

Comment thread test/test_jit.py
super(M, self).__init__()
self.p0 = nn.Parameter(torch.tensor([0.3], dtype=torch.float,
device=cpu_device_str))
device=cpu_device_str))
Copy link
Copy Markdown
Contributor

@mrshenli mrshenli Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent? nvm, my bad

Comment thread test/distributed/test_data_parallel.py Outdated
This PR remove pytorch specific defined assertwarns and use the unit
test one, also format some tests

[ghstack-poisoned]
This PR remove pytorch specific defined assertwarns and use the unit
test one, also format some tests

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@wanchaol merged this pull request in 3526627.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@wanchaol merged this pull request in 3526627.

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/96/head branch April 17, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#36411

This PR remove pytorch specific defined assertwarns and use the unit
test one, also format some tests

Test Plan: Imported from OSS

Differential Revision: D20998159

Pulled By: wanchaol

fbshipit-source-id: 1280ecff2dd293b95a639d13cc7417fc819c2201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants