Adding Conv1d to quantization default_mappings#36352
Closed
z-a-f wants to merge 1 commit intogh/z-a-f/9/basefrom
Closed
Adding Conv1d to quantization default_mappings#36352z-a-f wants to merge 1 commit intogh/z-a-f/9/basefrom
z-a-f wants to merge 1 commit intogh/z-a-f/9/basefrom
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 99baf1c (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_xenial_py3_6_clang7_test is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
dskhudia
approved these changes
Apr 9, 2020
supriyar
reviewed
Apr 9, 2020
| nn.Linear: nnq.Linear, | ||
| nn.ReLU: nnq.ReLU, | ||
| nn.ReLU6: nnq.ReLU6, | ||
| nn.Conv1d: nnq.Conv1d, |
Contributor
There was a problem hiding this comment.
Do we need to change for qat mapping as well?
Author
There was a problem hiding this comment.
I will send qat conv1d later (P1 for now :))
Contributor
1 similar comment
Contributor
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
Summary: Pull Request resolved: pytorch#36352 Test Plan: Imported from OSS Differential Revision: D20955781 Pulled By: z-a-f fbshipit-source-id: 37fbcf329a6abcd9a367a73ad65ce543ed9ffe47
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36352 Test Plan: Imported from OSS Differential Revision: D20955781 Pulled By: z-a-f fbshipit-source-id: 37fbcf329a6abcd9a367a73ad65ce543ed9ffe47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D20955781