Move FakeFP16 back to internal to remove dependency on MKL#36297
Closed
jianyuh wants to merge 1 commit intopytorch:masterfrom
Closed
Move FakeFP16 back to internal to remove dependency on MKL#36297jianyuh wants to merge 1 commit intopytorch:masterfrom
jianyuh wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20937962 |
💊 CircleCI build failures summary and remediationsAs of commit c49dd03 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 times. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20937962 |
b500533 to
dbf0133
Compare
…6297) Summary: Pull Request resolved: pytorch#36297 Pull Request resolved: pytorch/FBGEMM#343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Test Plan: CI Differential Revision: D20937962 fbshipit-source-id: d139c5e9c9911158aa09aa9b3ad76c88e7404afa
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Apr 9, 2020
Summary: Pull Request resolved: pytorch/pytorch#36297 Pull Request resolved: pytorch#343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Differential Revision: D20937962 fbshipit-source-id: daf6fbd55080bfa047651220ea3b97abde135fe0
dbf0133 to
c49dd03
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D20937962 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 10, 2020
Summary: Pull Request resolved: #36297 Pull Request resolved: pytorch/FBGEMM#343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Test Plan: CI Reviewed By: jspark1105 Differential Revision: D20937962 fbshipit-source-id: 9487a9fd2282b6df2f754c22bea36f2255a5c791
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
…6297) Summary: Pull Request resolved: pytorch#36297 Pull Request resolved: pytorch/FBGEMM#343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Test Plan: CI Reviewed By: jspark1105 Differential Revision: D20937962 fbshipit-source-id: 9487a9fd2282b6df2f754c22bea36f2255a5c791
pytorch-bot Bot
pushed a commit
to pytorch/FBGEMM
that referenced
this pull request
Feb 26, 2026
Summary: Pull Request resolved: pytorch/pytorch#36297 Pull Request resolved: #343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Reviewed By: jspark1105 Differential Revision: D20937962 fbshipit-source-id: 9487a9fd2282b6df2f754c22bea36f2255a5c791
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…6297) Summary: Pull Request resolved: pytorch#36297 Pull Request resolved: pytorch/FBGEMM#343 We moved FakeFP16 back to close source and kept `RoundToFloat16` function in "fbgemm/FbgemmConvert.h". This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere. Test Plan: CI Reviewed By: jspark1105 Differential Revision: D20937962 fbshipit-source-id: 9487a9fd2282b6df2f754c22bea36f2255a5c791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We moved FakeFP16 back to close source and kept
RoundToFloat16function in "fbgemm/FbgemmConvert.h".This is because FakeFP16 introduced dependency on MKL in the FBGEMM core. Also it doesn't seem to be needed for open source, as it is not used anywhere.
Test Plan: CI
Differential Revision: D20937962