[RPC x JIT] Integrate Python RPC TorchScript call with profiler#36266
Closed
xush6528 wants to merge 2 commits intogh/xush6528/87/basefrom
Closed
[RPC x JIT] Integrate Python RPC TorchScript call with profiler#36266xush6528 wants to merge 2 commits intogh/xush6528/87/basefrom
xush6528 wants to merge 2 commits intogh/xush6528/87/basefrom
Conversation
RecordFunction start but never end at an appropriate location. Might be recording wrong time number. Differential Revision: [D7857991](https://our.internmc.facebook.com/intern/diff/D7857991/) [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit a23369e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 times. |
rohan-varma
reviewed
Apr 8, 2020
torch/csrc/distributed/rpc/init.cpp
Outdated
| const py::args& args, | ||
| const py::kwargs& kwargs) { | ||
| const std::shared_ptr<torch::autograd::profiler::RecordFunction>& | ||
| rf const py::args& args, |
Contributor
There was a problem hiding this comment.
This won't compile, right? Missing comma between rf and next arg?
rohan-varma
suggested changes
Apr 8, 2020
Contributor
rohan-varma
left a comment
There was a problem hiding this comment.
Don't we need to make the relevant API changes in torchscript_functions.h? Also, will adding the extra arg cause any errors with the JIT call in register_distributed_ops? I'm assuming that if we default RecordFunction to nullptr, then it should be fine we and we won't have to make any JIT changes.
…filer" RecordFunction start but never end at an appropriate location. Might be recording wrong time number. Differential Revision: [D7857991](https://our.internmc.facebook.com/intern/diff/D7857991/) [ghstack-poisoned]
xush6528
added a commit
that referenced
this pull request
Apr 8, 2020
Pull Request resolved: #36266 RecordFunction starts but never ends at an appropriate location. Might be recording wrong time numbers. This is following up on #32197 and #32466 ghstack-source-id: 101798149 Differential Revision: [D7857991](https://our.internmc.facebook.com/intern/diff/D7857991/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
RecordFunction starts but never ends at an appropriate location. Might be recording wrong time numbers.
This is following up on
#32197
and
#32466
Differential Revision: D7857991