Skip to content

[JIT] fix alias assertion#36178

Closed
eellison wants to merge 3 commits intopytorch:masterfrom
eellison:fix_alias_any_assertion
Closed

[JIT] fix alias assertion#36178
eellison wants to merge 3 commits intopytorch:masterfrom
eellison:fix_alias_any_assertion

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented Apr 7, 2020

AnyType wasn't listed as a mutable type, so the assertion triggered (yay!). Also update the isMutableTypeInternal(from) != isMutableTypeInternal logic to be more encompassing.

@eellison eellison requested review from driazati, suo and zdevito April 7, 2020 22:28
@eellison eellison requested a review from apaszke as a code owner April 7, 2020 22:28
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 7, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 7, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit a9073f0 (more details on the Dr. CI page):

  • 1/2 failures introduced in this PR

  • 1/2 broken upstream at merge base 16d9bcd from Apr 06 until Apr 07 (9 commits; 2e8f954 - 444073e)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_build (1/1)

Step: "Build" (full log | pattern match details | 🔁 rerun) <confirmed not flaky by 2 failures>

ERROR: The process "sccache.exe" not found. 
curl --retry 3 -k https://s3.amazonaws.com/ossci-windows/sccache.exe --output C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   
 curl --retry 3 -k https://s3.amazonaws.com/ossci-windows/sccache-cl.exe --output C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe  
)  else ( 
aws s3 cp s3://ossci-windows/sccache.exe C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   
 aws s3 cp s3://ossci-windows/sccache-cl.exe C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe  
)   
 goto :check_sccache  
) )  
'C:\Users\circleci\project\build\win_tmp\bin\sccache.exe' is not recognized as an internal or external command, 
operable program or batch file. 
ERROR: The process "sccache.exe" not found. 
Could Not Find C:\Users\circleci\project\build\win_tmp\bin\sccache.exe 
Could Not Find C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe 
Completed 5.0 MiB/5.3 MiB (22.1 MiB/s) with 1 file(s) remaining  Completed 5.2 MiB/5.3 MiB (23.0 MiB/s) with 1 file(s) remaining  Completed 5.3 MiB/5.3 MiB (22.9 MiB/s) with 1 file(s) remaining  download: s3://ossci-windows/sccache.exe to build\win_tmp\bin\sccache.exe 
Completed 25.0 KiB/25.0 KiB (228.6 KiB/s) with 1 file(s) remaining download: s3://ossci-windows/sccache-cl.exe to build\win_tmp\bin\sccache-cl.exe 
 
circleci@PACKER-5E70C994 C:\Users\circleci\project>C:\Users\circleci\project\build\win_tmp\bin\sccache.exe --show-stats   || ( 
taskkill /im sccache.exe /f /t   || ver  1>nul   
 del C:\Users\circleci\project\build\win_tmp\bin\sccache.exe   || ver  1>nul   
 del C:\Users\circleci\project\build\win_tmp\bin\sccache-cl.exe   || ver  1>nul   
 if "pytorch-win-ws2019-cuda10-cudnn7-py3" == "" (

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 7 times.

@eellison eellison removed the request for review from driazati April 8, 2020 17:34
facebook-github-bot
facebook-github-bot reviewed Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito
zdevito approved these changes Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, but it may be possible to make the code paths' intent clearer.

Comment thread torch/csrc/jit/ir/alias_analysis.cpp Outdated
facebook-github-bot
facebook-github-bot reviewed Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@suo suo removed their request for review April 9, 2020 21:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 10, 2020

@eellison merged this pull request in 8cb1950.

ashishfarmer pushed a commit to ashishfarmer/pytorch that referenced this pull request Apr 13, 2020
[JIT] fix alias assertion (pytorch#36178)
2954cd9 
Summary:
AnyType wasn't listed as a mutable type, so the assertion triggered (yay!). Also update the `isMutableTypeInternal(from) != isMutableTypeInternal` logic to be more encompassing.
Pull Request resolved: pytorch#36178

Differential Revision: D20922356

Pulled By: eellison

fbshipit-source-id: 7060a62b18e98dc24b6004a66225c196aadb566e
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[JIT] fix alias assertion (pytorch#36178)
6836cf3 
Summary:
AnyType wasn't listed as a mutable type, so the assertion triggered (yay!). Also update the `isMutableTypeInternal(from) != isMutableTypeInternal` logic to be more encompassing.
Pull Request resolved: pytorch#36178

Differential Revision: D20922356

Pulled By: eellison

fbshipit-source-id: 7060a62b18e98dc24b6004a66225c196aadb566e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eellison @facebook-github-bot @zdevito @mruberry