[RELAND] Add __torch_function__ benchmarks#36138
[RELAND] Add __torch_function__ benchmarks#36138hameerabbasi wants to merge 6 commits intomasterfrom
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 24378c4 (more details on the Dr. CI page):
2 jobs timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 21 times. |
e69ae62 to
bf48df6
Compare
ezyang
left a comment
There was a problem hiding this comment.
waiting on CI. For reference, can you cross reference the previous time we landed this PR?
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Out of the three failures:
|
|
The ASAN failure is very clearly related to the code you added though, because it's reporting UB when running bench.py. You're probably dividing by zero from userland and that is triggering UBSAN... |
| bench_time = float(torch.min(torch.Tensor(bench_times))) / 1000 | ||
| bench_std = float(torch.std(torch.Tensor(bench_times))) / 1000 |
There was a problem hiding this comment.
@ezyang Only division happens here, and it's by 1000, not 0. Elsewhere I'm only doing torch.add.
There was a problem hiding this comment.
Got it, torch.std has UB with a length-1 Tensor.
55e32c8 to
79bfa6b
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
If you think std shouldn't UB when passed a one length tensor (a view I'm sympathetic with), file a bug report! |
1823929 to
dd63c44
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Re-land of pytorch#35530 and pytorch#34645 Pull Request resolved: pytorch#36138 Differential Revision: D20893770 Pulled By: ezyang fbshipit-source-id: 75ab688a086f5fb87412a853df5246c0c39704ca
Summary: Re-land of pytorch#35530 and pytorch#34645 Pull Request resolved: pytorch#36138 Differential Revision: D20893770 Pulled By: ezyang fbshipit-source-id: 75ab688a086f5fb87412a853df5246c0c39704ca
Re-land of #35530 and #34645