Skip to content

Add comparison operators to Vec256<BFloat16>#36106

Closed
xuhdev wants to merge 4 commits intogh/xuhdev/70/basefrom
gh/xuhdev/70/head
Closed

Add comparison operators to Vec256<BFloat16>#36106
xuhdev wants to merge 4 commits intogh/xuhdev/70/basefrom
gh/xuhdev/70/head

Conversation

@xuhdev
Copy link
Copy Markdown
Collaborator

@xuhdev xuhdev commented Apr 6, 2020

Stack from ghstack:

Differential Revision: D20927638

This is a dependency of #35117

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 6, 2020

💊 CircleCI build failures summary and remediations

As of commit a07205f (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 2/2 broken upstream at merge base 8afa001 since Apr 07

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 2 upstream failures:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 21 times.

This is a dependency of #35117

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Apr 6, 2020
This is a dependency of #35117

ghstack-source-id: b547bfa
Pull Request resolved: #36106
@XiaobingSuper
Copy link
Copy Markdown
Collaborator

@xuhdev , there has PR #35092 doing this, in progress of landing. Thanks!

This is a dependency of #35117

[ghstack-poisoned]
xuhdev added a commit that referenced this pull request Apr 7, 2020
…ary_op_as_fp32

ghstack-source-id: e39e3ca
Pull Request resolved: #36106
@xuhdev
Copy link
Copy Markdown
Collaborator Author

xuhdev commented Apr 7, 2020

@XiaobingSuper I've resolved conflicts. Please review, thanks!

@XiaobingSuper XiaobingSuper requested a review from ngimel April 7, 2020 04:23
@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented Apr 7, 2020

@xuhdev @XiaobingSuper I'm confused, the previous PR in this stack enables +-/* operations for bfloat16 which are already enabled in one of @XiaobingSuper's PRs? If the previous PR is not actually needed can you close it and have this PR unstacked?

@xuhdev
Copy link
Copy Markdown
Collaborator Author

xuhdev commented Apr 7, 2020

@ngimel The previous PR is a cleanup of the operators -- it did not add the operators

xuhdev added a commit that referenced this pull request Apr 7, 2020
…ary_op_as_fp32

ghstack-source-id: 1c6cfe2
Pull Request resolved: #36106
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ngimel merged this pull request in 3a88388.

@xuhdev xuhdev deleted the gh/xuhdev/70/head branch April 9, 2020 21:02
ashishfarmer pushed a commit to ashishfarmer/pytorch that referenced this pull request Apr 13, 2020
Summary: Pull Request resolved: pytorch#36106

Test Plan: Imported from OSS

Differential Revision: D20927638

Pulled By: ngimel

fbshipit-source-id: 6831747baab1af9d794011e2c7ae0291828dea2b
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#36106

Test Plan: Imported from OSS

Differential Revision: D20927638

Pulled By: ngimel

fbshipit-source-id: 6831747baab1af9d794011e2c7ae0291828dea2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants