Refactor thread_reduce for better unrolling and vectorization in the future by zasdfgbnm · Pull Request #36014 · pytorch/pytorch

zasdfgbnm · 2020-04-04T03:20:08Z

Stack from ghstack:

Refactor thread_reduce for better unrolling and vectorization in the future #36014 Refactor thread_reduce for better unrolling and vectorization in the future
Target 8192 blocks instead of split to large grid for large reduction #35997 Target 4096 blocks instead of split to large grid for large reduction

Benchmark on RTX2080Ti: 2.13ms vs 1.88ms
https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb

Differential Revision: D20927535

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

dr-ci · 2020-04-04T03:21:00Z

💊 CircleCI build failures summary and remediations

As of commit f819b0b (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

3/3 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

❄️ 3 tentatively flaky failures

3 failures tentatively classified as flaky but have not triggered reruns to confirm:

pytorch_cpp_doc_push (1/3)

Step: "Set Up CI Environment After attach_workspace" (full log | pattern match details | 🔁 rerun) ❄️

E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http:

Reading package lists... 99%  Reading package lists... Done  
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://cli-assets.heroku.com/apt ./ InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
W: The repository 'http://ppa.launchpad.net/git-core/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: The repository 'http://ppa.launchpad.net/openjdk-r/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: Failed to fetch https://cli-assets.heroku.com/apt/./InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
E: Failed to fetch http://ppa.launchpad.net/git-core/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
W: Some index files failed to download. They have been ignored, or old ones used instead.

pytorch_linux_xenial_py3_6_gcc5_4_test (2/3)

Step: "Set Up CI Environment After attach_workspace" (full log | pattern match details | 🔁 rerun) ❄️

E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http:

Reading package lists... 99%  Reading package lists... Done  
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://cli-assets.heroku.com/apt ./ InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
W: The repository 'http://ppa.launchpad.net/git-core/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: The repository 'http://ppa.launchpad.net/openjdk-r/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: Failed to fetch https://cli-assets.heroku.com/apt/./InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
E: Failed to fetch http://ppa.launchpad.net/git-core/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
W: Some index files failed to download. They have been ignored, or old ones used instead.

pytorch_python_doc_push (3/3)

Step: "Set Up CI Environment After attach_workspace" (full log | pattern match details | 🔁 rerun) ❄️

E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http:

Reading package lists... 99%  Reading package lists... Done  
W: An error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: https://cli-assets.heroku.com/apt ./ InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
W: The repository 'http://ppa.launchpad.net/git-core/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: The repository 'http://ppa.launchpad.net/openjdk-r/ppa/ubuntu xenial Release' does not have a Release file. 
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. 
N: See apt-secure(8) manpage for repository creation and user configuration details. 
W: Failed to fetch https://cli-assets.heroku.com/apt/./InRelease  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5DC22404A6F9F1CA 
E: Failed to fetch http://ppa.launchpad.net/git-core/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
E: Failed to fetch http://ppa.launchpad.net/openjdk-r/ppa/ubuntu/dists/xenial/main/binary-amd64/Packages  Unable to connect to ppa.launchpad.net:http: 
W: Some index files failed to download. They have been ignored, or old ones used instead.

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 18 times.

zasdfgbnm · 2020-04-04T04:16:06Z

How can every test pass on my system and fails here...

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb ghstack-source-id: 074b2ef Pull Request resolved: #36014

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb ghstack-source-id: 2dd4e56 Pull Request resolved: #36014

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb Differential Revision: [D20927535](https://our.internmc.facebook.com/intern/diff/D20927535) [ghstack-poisoned]

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb ghstack-source-id: e41085c Pull Request resolved: #36014

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb Differential Revision: [D20927535](https://our.internmc.facebook.com/intern/diff/D20927535) [ghstack-poisoned]

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb ghstack-source-id: fa34216 Pull Request resolved: #36014

facebook-github-bot · 2020-04-10T03:51:09Z

@ngimel merged this pull request in 3d7c9ab.

…future (pytorch#36014) Summary: Pull Request resolved: pytorch#36014 Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb Test Plan: Imported from OSS Differential Revision: D20927535 Pulled By: ngimel fbshipit-source-id: b65b749b58cebe0751e4ec7e1cf359543c401580

Refactor thread_reduce for better unrolling and vectorization in the …

a4f5c52

…future Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

zasdfgbnm mentioned this pull request Apr 4, 2020

Target 8192 blocks instead of split to large grid for large reduction #35997

Closed

pytorchbot added the open source label Apr 4, 2020

Update on "Refactor thread_reduce for better unrolling and vectorizat…

912574f

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

Update on "Refactor thread_reduce for better unrolling and vectorizat…

4037d20

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

zasdfgbnm requested review from jjsjann123 and ngimel April 4, 2020 09:03

Update on "Refactor thread_reduce for better unrolling and vectorizat…

e13530e

…ion in the future" Benchmark on RTX2080Ti: 2.13ms vs 1.88ms https://github.com/zasdfgbnm/things/blob/master/2020Q2/reduction-benchmark-refactor.ipynb [ghstack-poisoned]

zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 6, 2020

ngimel approved these changes Apr 8, 2020

View reviewed changes

facebook-github-bot closed this in 3d7c9ab Apr 10, 2020

facebook-github-bot added the merged label Apr 10, 2020

zasdfgbnm deleted the gh/zasdfgbnm/34/head branch April 10, 2020 10:18

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor thread_reduce for better unrolling and vectorization in the future#36014

Refactor thread_reduce for better unrolling and vectorization in the future#36014
zasdfgbnm wants to merge 6 commits intogh/zasdfgbnm/34/basefrom
gh/zasdfgbnm/34/head

zasdfgbnm commented Apr 4, 2020 •

edited by ngimel

Loading

Uh oh!

dr-ci Bot commented Apr 4, 2020 •

edited

Loading

Uh oh!

zasdfgbnm commented Apr 4, 2020

Uh oh!

facebook-github-bot commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

zasdfgbnm commented Apr 4, 2020 • edited by ngimel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Apr 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

❄️ 3 tentatively flaky failures

pytorch_cpp_doc_push (1/3)

pytorch_linux_xenial_py3_6_gcc5_4_test (2/3)

pytorch_python_doc_push (3/3)

Uh oh!

zasdfgbnm commented Apr 4, 2020

Uh oh!

facebook-github-bot commented Apr 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zasdfgbnm commented Apr 4, 2020 •

edited by ngimel

Loading

dr-ci Bot commented Apr 4, 2020 •

edited

Loading