float2::x and float2::y may not be the same as float on ROCm#35593
Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
Closed
float2::x and float2::y may not be the same as float on ROCm#35593xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CircleCI build failures summary and remediationsAs of commit a4c7075 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 upstream failure:These were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 9 times. |
This causes ambiguity and can be triggered sometimes (e.g., by pytorch#35217). Explicitly convert them to float. error: conditional expression is ambiguous; 'const hip_impl::Scalar_accessor<float, Native_vec_, 0>' can be converted to 'float' and vice versa
ezyang
approved these changes
Mar 30, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Contributor
|
it looks like we may need to port this to 1.5, ROCm tests are failing in a similar way. |
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Mar 31, 2020
…pytorch#35593) Summary: This causes ambiguity and can be triggered sometimes (e.g., by pytorch#35217). Explicitly convert them to float. error: conditional expression is ambiguous; 'const hip_impl::Scalar_accessor<float, Native_vec_, 0>' can be converted to 'float' and vice versa Pull Request resolved: pytorch#35593 Differential Revision: D20735663 Pulled By: ezyang fbshipit-source-id: ae6a38a08e59821bae13eb0b9f9bdf21a008d5c0
This was referenced Mar 31, 2020
Contributor
|
porting this looks necessary but not sufficient for 1.5, see #35784. |
gchanan
pushed a commit
that referenced
this pull request
Mar 31, 2020
…#35593) Summary: This causes ambiguity and can be triggered sometimes (e.g., by #35217). Explicitly convert them to float. error: conditional expression is ambiguous; 'const hip_impl::Scalar_accessor<float, Native_vec_, 0>' can be converted to 'float' and vice versa Pull Request resolved: #35593 Differential Revision: D20735663 Pulled By: ezyang fbshipit-source-id: ae6a38a08e59821bae13eb0b9f9bdf21a008d5c0
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…#35593) Summary: This causes ambiguity and can be triggered sometimes (e.g., by pytorch#35217). Explicitly convert them to float. error: conditional expression is ambiguous; 'const hip_impl::Scalar_accessor<float, Native_vec_, 0>' can be converted to 'float' and vice versa Pull Request resolved: pytorch#35593 Differential Revision: D20735663 Pulled By: ezyang fbshipit-source-id: ae6a38a08e59821bae13eb0b9f9bdf21a008d5c0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes ambiguity and can be triggered sometimes (e.g., by #35217). Explicitly convert them to float.