Skip to content

Enable NNC's LLVM dependency in CI#35564

Closed
resistor wants to merge 2 commits intopytorch:masterfrom
resistor:nnc-ci
Closed

Enable NNC's LLVM dependency in CI#35564
resistor wants to merge 2 commits intopytorch:masterfrom
resistor:nnc-ci

Conversation

@resistor
Copy link
Copy Markdown
Contributor

@resistor resistor commented Mar 27, 2020

No description provided.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 27, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit b511f7f (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_python_doc_push (1/2)

Step: "Doc Build and Push" (full log | pattern match details) <confirmed not flaky by 2 failures>

Apr 06 18:54:23 Could not import extension javasphinx (exception: cannot import name 'l_') 
Apr 06 18:54:21 Saved activation image for GELU() at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/GELU.png 
Apr 06 18:54:21 Saved activation image for Sigmoid() at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Sigmoid.png 
Apr 06 18:54:21 Saved activation image for Softplus(beta=1, threshold=20) at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Softplus.png 
Apr 06 18:54:21 Saved activation image for Softshrink(0.5) at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Softshrink.png 
Apr 06 18:54:21 Saved activation image for Softsign() at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Softsign.png 
Apr 06 18:54:21 Saved activation image for Tanh() at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Tanh.png 
Apr 06 18:54:21 Saved activation image for Tanhshrink() at /var/lib/jenkins/workspace/docs/source/scripts/activation_images/Tanhshrink.png 
Apr 06 18:54:22 Running Sphinx v3.0.0 
Apr 06 18:54:23  
Apr 06 18:54:23 Extension error: 
Apr 06 18:54:23 Could not import extension javasphinx (exception: cannot import name 'l_') 
Apr 06 18:54:23 make: *** [html] Error 2 
Apr 06 18:54:23 Makefile:38: recipe for target 'html' failed

See CircleCI build pytorch_cpp_doc_push (2/2)

Step: "Doc Build and Push" (full log | pattern match details) <confirmed not flaky by 2 failures>

Apr 06 18:54:51 - [class]: torch::serialize::OutputArchive 
Apr 06 18:54:51     - [function]: torch::python::bind_module 
Apr 06 18:54:51     - [function]: torch::python::bind_module 
Apr 06 18:54:51     - [function]: torch::python::init_bindings 
Apr 06 18:54:51     - [namespace]: torch::python::detail 
Apr 06 18:54:51       - [function]: torch::python::detail::bind_cpp_module_wrapper 
Apr 06 18:54:51       - [function]: torch::python::detail::py_object_to_device 
Apr 06 18:54:51       - [function]: torch::python::detail::py_object_to_dtype 
Apr 06 18:54:51       - [typedef]: torch::python::detail::PyModuleClass 
Apr 06 18:54:51   - [namespace]: torch::serialize 
Apr 06 18:54:51     - [class]: torch::serialize::InputArchive 
Apr 06 18:54:51     - [class]: torch::serialize::OutputArchive 
Apr 06 18:54:51   - [typedef]: torch::AutoGradMode 
Apr 06 18:54:51   - [typedef]: torch::Deleter 
Apr 06 18:54:51   - [typedef]: torch::Dtype 
Apr 06 18:54:51   - [typedef]: torch::NoGradGuard 
Apr 06 18:54:51   - [variable]: torch::kArea 
Apr 06 18:54:51   - [variable]: torch::kBatchMean 
Apr 06 18:54:51   - [variable]: torch::kBicubic 
Apr 06 18:54:51   - [variable]: torch::kBilinear 
Apr 06 18:54:51   - [variable]: torch::kBorder 
Apr 06 18:54:51   - [variable]: torch::kCircular
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 128 times.

@resistor resistor force-pushed the nnc-ci branch 8 times, most recently from f8924cc to 0c7fc62 Compare March 28, 2020 05:33
@resistor resistor requested a review from Krovatkin March 31, 2020 16:35
Krovatkin
Krovatkin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread .circleci/config.yml Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed for testing?

Copy link
Copy Markdown
Contributor Author

@resistor resistor Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's needed to trigger the docker rebuild.

Comment thread .circleci/docker/ubuntu-cuda/Dockerfile Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are planning to extend install_llvm to use ninja if available, in future?

Copy link
Copy Markdown
Contributor Author

@resistor resistor Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifact from an earlier version of the patch. I'll eliminate it.

Comment thread .circleci/docker/common/install_llvm.sh Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity which option disables tests, otherwise i think we get linking issues if something else links in gtest?

Copy link
Copy Markdown
Contributor Author

@resistor resistor Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had any linking issues with test?

Krovatkin
Krovatkin reviewed Mar 31, 2020
View reviewed changes
Comment thread .circleci/docker/common/install_llvm.sh Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does jenkins user have reading permissions for /opt/llvm?

@resistor resistor force-pushed the nnc-ci branch 12 times, most recently from 7e8ee1c to 724efa3 Compare April 3, 2020 21:32
facebook-github-bot
facebook-github-bot reviewed Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@resistor resistor changed the title [WIP] Enable NNC's LLVM dependency in CI Enable NNC's LLVM dependency in CI Apr 6, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 7, 2020

@resistor merged this pull request in b8383b3.

ashishfarmer pushed a commit to ashishfarmer/pytorch that referenced this pull request Apr 13, 2020
[WIP] Enable NNC's LLVM dependency in CI (pytorch#35564)
bc5abf6 
Summary: Pull Request resolved: pytorch#35564

Differential Revision: D20848144

Pulled By: resistor

fbshipit-source-id: 992589447162766fbe8df0c696563511a2bb8e52
@seemethere seemethere mentioned this pull request Aug 17, 2020
Merged
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[WIP] Enable NNC's LLVM dependency in CI (pytorch#35564)
a556b16 
Summary: Pull Request resolved: pytorch#35564

Differential Revision: D20848144

Pulled By: resistor

fbshipit-source-id: 992589447162766fbe8df0c696563511a2bb8e52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Krovatkin Krovatkin Krovatkin approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@resistor @facebook-github-bot @Krovatkin @mruberry