Quantized ConvTranspose2d#35371
Closed
z-a-f wants to merge 11 commits intogh/z-a-f/5/basefrom
Closed
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 8661e92 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 27 times. |
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
jerryzh168
reviewed
Mar 25, 2020
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
jerryzh168
reviewed
Mar 25, 2020
|
|
||
| # TODO(z-a-f): Once the quantized `.flip` is implemented, | ||
| # we can remove the requantization | ||
| qscale = w.q_scale() |
Contributor
There was a problem hiding this comment.
wait, what if weight is per channel quantized?
Author
There was a problem hiding this comment.
Not supported yet -- I will send a PR with the per-channel support later on. For now, raising an error
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Author
|
Coming up: unittests |
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
Differential Revision: [D20641811](https://our.internmc.facebook.com/intern/diff/D20641811)
MauiDesign
pushed a commit
to MauiDesign/PyTorchPyTorch
that referenced
this pull request
Aug 16, 2020
ghstack-source-id: 649ea21 Pull Request resolved: pytorch/pytorch#35371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D20641811