That's cool. I guess we can't easily run tests that require nvprof in our CI, but can you guys add a test in yours? Also, what's the plan for when nvprof is no longer supported, and there's only nsight systems?

💊 CircleCI build failures summary and remediations

As of commit 516687b (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

• 4/4 broken upstream at merge base e5ee95e since Mar 19

  Please rebase on the viable/strict branch (expand for instructions)

  If your commit is newer than viable/strict, you can try basing on an older, stable commit:

  git fetch https://github.com/pytorch/pytorch viable/strict
  git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
  

  If your commit is older than viable/strict:

  git fetch https://github.com/pytorch/pytorch viable/strict
  git rebase FETCH_HEAD
  

  Check out the recency history of this "viable master" tracking branch.

🚧 4 upstream failures:

These were probably caused by upstream breakages:

• pytorch_windows_vs2019_py36_cuda10.1_build since Mar 19
• pytorch_linux_xenial_py3_6_gcc5_4_test since Mar 19
• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test on Mar 19 from 12:06am to 4:56am (12 commits; 4521477 - be82e55)
• pytorch_linux_xenial_py3_clang5_asan_test on Mar 19 from 12:06am to 4:56am (12 commits; 4521477 - be82e55)

This seems pretty harmless to accept.

@ngimel Xiao has written the test and we'll add it to our CI.
nvprof/nsys needs some offline discussion.

@ezyang merged this pull request in a5b5ea9.