Skip to content

[C++ API Parity] Add xor_convergence test for lbfgs#35001

Closed
anjali411 wants to merge 4 commits intopytorch:masterfrom
anjali411:lbfgs_xor_tests
Closed

[C++ API Parity] Add xor_convergence test for lbfgs#35001
anjali411 wants to merge 4 commits intopytorch:masterfrom
anjali411:lbfgs_xor_tests

Conversation

@anjali411
Copy link
Copy Markdown
Contributor

@anjali411 anjali411 commented Mar 18, 2020

No description provided.

@anjali411 anjali411 added the module: cpp Related to C++ API label Mar 18, 2020
yf225
yf225 reviewed Mar 18, 2020
View reviewed changes
Comment thread test/cpp/api/optim.cpp Outdated
yf225
yf225 approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome work!

facebook-github-bot
facebook-github-bot reviewed Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 19, 2020

@anjali411 merged this pull request in 4521477.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 19, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit d75d0bc (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 8 times.

@mrshenli
Copy link
Copy Markdown
Contributor

mrshenli commented Mar 19, 2020

Looks like this PR breaks master @anjali411

https://app.circleci.com/pipelines/github/pytorch/pytorch/142016/workflows/58f4e55c-7806-4db8-b48e-1d87a3ccc08e/jobs/4864445

@anjali411 anjali411 reopened this Mar 19, 2020
@yf225
Copy link
Copy Markdown
Contributor

yf225 commented Mar 19, 2020

I tried const int64_t kBatchSize = 50; and it seems to work locally (not sure why kBatchSize = 6 was failing locally for me)

@anjali411 anjali411 removed the merged label Mar 19, 2020
facebook-github-bot
facebook-github-bot reviewed Mar 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 20, 2020

@anjali411 merged this pull request in 781f590.

@yf225 yf225 modified the milestone: 1.5.0 Mar 20, 2020
@yf225 yf225 mentioned this pull request Mar 20, 2020
Closed
@anjali411 anjali411 mentioned this pull request Mar 23, 2020
Merged
This was referenced Mar 24, 2020
Closed
Merged
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@anjali411 @facebook-github-bot
[C++ API Parity] Add xor_convergence test for lbfgs (pytorch#35001)
f4fb299 
Summary: Pull Request resolved: pytorch#35001

Differential Revision: D20524479

Pulled By: anjali411

fbshipit-source-id: 3413779676ab95c1ee82298f95d3441a89873107
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@anjali411 @facebook-github-bot
[C++ API Parity] Add xor_convergence test for lbfgs (pytorch#35001)
37fbba8 
Summary: Pull Request resolved: pytorch#35001

Differential Revision: D20548983

Pulled By: anjali411

fbshipit-source-id: 1f858635d0680c0109d1ef348b7df4d3844fe0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebetica ebetica Awaiting requested review from ebetica

@goldsborough goldsborough Awaiting requested review from goldsborough

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@yf225 yf225 yf225 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @facebook-github-bot @mrshenli @yf225 @mruberry