in test_data_parallel.py, remove skipIfRocm from tests that pass#34978
Closed
jeffdaily wants to merge 1 commit intopytorch:masterfrom
Closed
in test_data_parallel.py, remove skipIfRocm from tests that pass#34978jeffdaily wants to merge 1 commit intopytorch:masterfrom
jeffdaily wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
Test passed three iterations on the CI, no flakiness detected. |
Contributor
|
Changes look good, will approve once the rocm CI passes. |
💊 CircleCI build failures summary and remediationsAs of commit 81e473f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
mrshenli
approved these changes
Mar 19, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…orch#34978) Summary: Pull Request resolved: pytorch#34978 Differential Revision: D20535920 Pulled By: mrshenli fbshipit-source-id: 3baa8608dd3b0dd5578bc32e56a2e6c1fe69492d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.