Skip to content

Fix flake#34974

Closed
eellison wants to merge 1 commit intopytorch:masterfrom
eellison:fix_py2_flake
Closed

Fix flake#34974
eellison wants to merge 1 commit intopytorch:masterfrom
eellison:fix_py2_flake

Conversation

@eellison
Copy link
Copy Markdown
Contributor

fix flake, add overload names

@eellison eellison requested a review from apaszke as a code owner March 18, 2020 20:02
@eellison eellison requested a review from mruberry March 18, 2020 20:02
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 18, 2020
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 19, 2020

💊 CircleCI build failures summary and remediations

As of commit 61f68a7 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base 1afc584 on Mar 18 from 2:35pm to 7:57pm (10 commits; d927d58 - c747f09)

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@eellison merged this pull request in bcbde49.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
fix flake, add overload names
Pull Request resolved: pytorch#34974

Differential Revision: D20519191

Pulled By: eellison

fbshipit-source-id: d08d36b64397287cad484690074e694d8a0e472e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants