Skip to content

Add guard elimination cases for operators encountered on an RL workload.#34967

Closed
resistor wants to merge 1 commit intopytorch:masterfrom
resistor:master
Closed

Add guard elimination cases for operators encountered on an RL workload.#34967
resistor wants to merge 1 commit intopytorch:masterfrom
resistor:master

Conversation

@resistor
Copy link
Copy Markdown
Contributor

@resistor resistor commented Mar 18, 2020

No description provided.

@resistor resistor requested a review from Krovatkin March 18, 2020 18:23
@resistor resistor requested a review from apaszke as a code owner March 18, 2020 18:23
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 18, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 18, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit a31cb90 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 3/3 broken upstream at merge base fd57e09 from Mar 19 until Mar 20 (9 commits; 733b631 - e7fc55e)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🚧 2 upstream failures:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 4 times.

Krovatkin
Krovatkin suggested changes Mar 19, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/guard_elimination.cpp Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know what stacklevel does?

Copy link
Copy Markdown
Contributor Author

@resistor resistor Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output shape is always the same as the input shape: https://pytorch.org/docs/stable/nn.html#torch.nn.Softmax2d

Comment thread torch/csrc/jit/passes/guard_elimination.cpp Outdated
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 6th argument of convXd seems to be the number of groups? Shouldn't that affect output shapes even if input and weights' shapes are fixed?

Copy link
Copy Markdown
Contributor Author

@resistor resistor Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groups affects the result values but not the shape.

facebook-github-bot
facebook-github-bot reviewed Mar 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 21, 2020

@resistor merged this pull request in 3c409fc.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@resistor @facebook-github-bot
Add guard elimination cases for operators encountered on an RL worklo…
666afe4 
…ad. (pytorch#34967)

Summary: Pull Request resolved: pytorch#34967

Differential Revision: D20547478

Pulled By: resistor

fbshipit-source-id: da7df159fd6098d0f1278b8088bbbe6717b79cfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@Krovatkin Krovatkin Krovatkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@resistor @facebook-github-bot @Krovatkin @mruberry