Skip to content

port the changes from bert/pytorch_fusion to guard_elimination.cpp#34942

Closed
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/port_ge
Closed

port the changes from bert/pytorch_fusion to guard_elimination.cpp#34942
Krovatkin wants to merge 1 commit intopytorch:masterfrom
Krovatkin:krovatkin/port_ge

Conversation

@Krovatkin
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin commented Mar 18, 2020 •
edited
Loading

This PR adds the cases for the following algebraic functions:

      case aten::_cast_Float:
      case aten::_sigmoid_backward:
      case aten::_tanh_backward:
      case aten::__and__:
      case aten::__or__:
      case aten::__xor__:
      case aten::__lshift__:
      case aten::__rshift__:

and reformats the whole file with clang-format.

@Krovatkin Krovatkin requested a review from apaszke as a code owner March 18, 2020 04:25
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 18, 2020
facebook-github-bot
facebook-github-bot reviewed Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ZolotukhinM
ZolotukhinM approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expand in the commit message what actual changes are in the PR (ideally, it would be 2 PRs). Also, "ge" abbreviation might not be an obvious for everyone.

@Krovatkin Krovatkin changed the title port ge changes from bert/pytorch_fusion port the changes from bert/pytorch_fusion to guard_elimination.cpp Mar 18, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 18, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit fe55bda (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 1/1 broken upstream at merge base 95f1cb3 since Mar 17

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 19, 2020

@Krovatkin merged this pull request in a4048b4.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@Krovatkin @facebook-github-bot
port ge changes from bert/pytorch_fusion (pytorch#34942)
2ecf937 
Summary: Pull Request resolved: pytorch#34942

Differential Revision: D20505894

Pulled By: Krovatkin

fbshipit-source-id: 7b442fae6aa2b1a29891b94f824094a1fddae4a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@resistor resistor Awaiting requested review from resistor

@apaszke apaszke Awaiting requested review from apaszke

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Krovatkin @facebook-github-bot @ZolotukhinM @mruberry