Extends true_divide to be a method by mruberry · Pull Request #34794 · pytorch/pytorch

mruberry · 2020-03-16T03:15:58Z

Per title. See related #34570.

In PyTorch 1.7 the plan is for torch.div and Python's division operator to perform "true" division, like Python 3, JAX, and NumPy. To facilitate this change, this PR expands true_divide to be a method so it can cover all of torch.div's use cases.

New true_divide tests are added to test_torch.py, test_type_promotion.py, and test_sparse.py.

dr-ci · 2020-03-16T03:18:12Z

💊 CircleCI build failures summary and remediations

As of commit e168911 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

1/1 broken upstream at merge base 3cd3f0b since Mar 23
Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
```
If your commit is older than viable/strict:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
```
Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 33 times.

…re_div

gchanan · 2020-03-17T22:58:31Z

    @float_double_default_dtype
    def test_true_divide(self, device, dtype):
-        dividend = torch.randn(5, device=device).to(dtype)
+        dividend = (torch.randn(5, device=device) * 100).to(dtype)


why do you multiply by 100?

To make the division more interesting. Example dividends:

(torch.randn(100)).long() : tensor([ 0, 0, -1, -2, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, -1, 0, 1, -1, 0, -1, 0, 0, 0, 0, 1, 0, 0, 0, -1, 1, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, -1, -1, 0, -1, 0, 0, 0, -1, 0, 0, -2, 0, 0, 0, 1, -1, 0, 0, -1, 0, 0, 0, 0, -1, 1, 0, 0, 0, -1, -1, 0, 0, -1, -1, 0, 0, 0, 2, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, -1, 0, 0, 1, 0, 1]) (torch.randn(100) * 100).long() : tensor([ 54, 113, 7, 69, 4, 98, -32, 223, -36, 285, -111, -6, -36, -43, 122, -39, -164, 101, -100, -122, -2, -70, 40, 121, 16, 21, 6, 21, -110, -35, -186, 193, 15, -21, 75, 61, -62, -27, -116, -32, -17, -159, -111, 56, -28, 59, -117, 63, -57, -49, 210, 93, 11, -107, -66, 32, -8, -150, -20, 46, 6, 98, -28, 87, 6, -124, -81, 42, -68, -14, -39, -149, 117, 48, -81, -120, -138, 183, 146, -43, -72, -53, -93, 67, -73, -161, 152, 57, -229, -37, 59, -85, 47, 178, -127, -110, 34, 175, -11, -39])

gchanan · 2020-03-17T22:58:42Z

+    @dtypes(torch.float, torch.double, torch.bool, torch.short, torch.uint8, torch.int, torch.long)
    def test_true_divide_out(self, device, dtype):
-        dividend = torch.randn(5, device=device).to(dtype)
+        dividend = (torch.randn(5, device=device) * 100).to(dtype)


See note above.

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…re_div

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-03-24T12:11:16Z

@mruberry merged this pull request in 7c1ea73.

Summary: Per title. See related pytorch#34570. In PyTorch 1.7 the plan is for torch.div and Python's division operator to perform "true" division, like Python 3, JAX, and NumPy. To facilitate this change, this PR expands true_divide to be a method so it can cover all of torch.div's use cases. New true_divide tests are added to test_torch.py, test_type_promotion.py, and test_sparse.py. Pull Request resolved: pytorch#34794 Differential Revision: D20545507 Pulled By: mruberry fbshipit-source-id: 55286f819716c8823d1930441a69008560ac2bd5

Mike Ruberry added 2 commits March 15, 2020 20:04

Adds future_div, method variant of true_divide

0da82fe

new line at eof

dac8c9f

This was referenced Mar 16, 2020

Warns when performing integer division with div and addcdiv #34570

Closed

Makes floor_divide a method, adds sparse floor division #34552

Closed

mruberry requested a review from gchanan March 16, 2020 16:22

mruberry added module: numpy Related to numpy support, and also numpy compatibility of our operators module: deprecation labels Mar 16, 2020

gchanan reviewed Mar 17, 2020

View reviewed changes

Comment thread test/test_torch.py Outdated

gchanan reviewed Mar 17, 2020

View reviewed changes

Comment thread torch/future_div.py Outdated

Mike Ruberry added 2 commits March 19, 2020 05:22

Merges

3f1602e

Rebases

01af894

mruberry changed the title ~~Adds torch.future_div and extends true_divide to be a method~~ Extends true_divide to be a method Mar 19, 2020

mruberry requested a review from gchanan March 19, 2020 16:27

Merge branch 'master' of https://github.com/pytorch/pytorch into futu…

517c23b

…re_div

gchanan reviewed Mar 19, 2020

View reviewed changes

Comment thread test/test_type_promotion.py Outdated

gchanan approved these changes Mar 19, 2020

View reviewed changes

Mike Ruberry added 2 commits March 19, 2020 14:53

Fixes integral dtypes consistency

fcc17ef

Fixes integral dtypes consistency

d0725e1

facebook-github-bot reviewed Mar 19, 2020

View reviewed changes

Merge branch 'master' of https://github.com/pytorch/pytorch into futu…

4be72fa

…re_div

facebook-github-bot reviewed Mar 23, 2020

View reviewed changes

mruberry added 2 commits March 23, 2020 14:18

Merge branch 'master' into future_div

0df7a07

Fixes gen-pyi

e168911

facebook-github-bot reviewed Mar 24, 2020

View reviewed changes

facebook-github-bot closed this in 7c1ea73 Mar 24, 2020

facebook-github-bot added the merged label Mar 24, 2020

This was referenced Mar 24, 2020

Ports UBSAN float->int conversion fix to 1.5 #35321

Merged

[v1.5.0] Release Tracker #35009

Closed

Ports true_divide method variant to 1.5 #35390

Merged

mruberry deleted the future_div branch May 16, 2020 05:04

mruberry added the Merged label Oct 28, 2020

Conversation

mruberry commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

Uh oh!

Uh oh!

Uh oh!

gchanan Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

mruberry Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

gchanan Mar 17, 2020

Choose a reason for hiding this comment

Uh oh!

mruberry Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mruberry commented Mar 16, 2020 •

edited

Loading

dr-ci Bot commented Mar 16, 2020 •

edited

Loading