Skip to content

[jit] Include call stack in OSError message#34669

Closed
driazati wants to merge 6 commits intomasterfrom
driazati/oserror
Closed

[jit] Include call stack in OSError message#34669
driazati wants to merge 6 commits intomasterfrom
driazati/oserror

Conversation

@driazati
Copy link
Copy Markdown
Contributor

@driazati driazati commented Mar 12, 2020

Previously there was no indication of why you would get an OSError for something (such as the generated methods of a dataclass).

Differential Revision: D20426570

@driazati driazati requested a review from apaszke as a code owner March 12, 2020 19:30
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 12, 2020
@driazati driazati requested review from asuhan, eellison and suo March 12, 2020 19:51
@driazati driazati removed the request for review from asuhan March 12, 2020 20:10
Copy link
Copy Markdown
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change. One question about defaulting of error_msg

Comment thread test/test_jit_py3.py Outdated
Comment thread test/test_jit_py3.py
Comment thread torch/_utils_internal.py
David Riazati and others added 2 commits March 13, 2020 14:15
@suo suo removed their request for review March 17, 2020 17:14
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@driazati merged this pull request in e35dd4f.

@facebook-github-bot facebook-github-bot deleted the driazati/oserror branch July 13, 2020 17:55
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Previously there was no indication of why you would get an `OSError` for something (such as the generated methods of a `dataclass`).
](https://our.intern.facebook.com/intern/diff/20426570/)
Pull Request resolved: pytorch#34669

Pulled By: driazati

Differential Revision: D20426570

fbshipit-source-id: 45d63631984fa26a87c03de5523fb10d8abbc6db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants