Remove hotpatches that circumvent MAGMA bug#34357
Remove hotpatches that circumvent MAGMA bug#34357vishwakftw wants to merge 4 commits intopytorch:masterfrom
Conversation
|
cc: @seemethere @soumith This PR requires that the CI images have the updated MAGMA binaries as well to pass tests. |
💊 CircleCI build failures summary and remediationsAs of commit 40a1f39 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 16 times. |
yf225
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix! @seemethere Wondering do you mind checking if our CI has MAGMA >= 2.5.2? Thanks!
|
CI should now be updated with the latest version of magma |
…ve-hotfix-lu-det
|
@seemethere thank you for confirming! |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@seemethere merged this pull request in cb06cb7. |
|
@seemethere merged this pull request in cb06cb7. |
|
We're still running CUDA 9 on master with the old version on MAGMA, which means this breaks master. You'll need to do something about that first before we can land this. |
|
@seemethere I believe we don't have MAGMA binaries for CUDA 9 on Anaconda either. |
Summary: Changelog: - The magma implementation of small singular square batch matrices had a bug that resulted in nan values in the LU factorization result. This has been fixed in MAGMA 2.5.2. This PR removes the existing patch that was a temporary workaround for this bug. Pull Request resolved: #35973 Test Plan: - Existing tests for det and lu should pass This is a re-submit of #34357 Differential Revision: D21336552 Pulled By: seemethere fbshipit-source-id: 9c3b350966913147f1d5811927f3cae10fe620f1
Summary: Changelog: - The magma implementation of small singular square batch matrices had a bug that resulted in nan values in the LU factorization result. This has been fixed in MAGMA 2.5.2. This PR removes the existing patch that was a temporary workaround for this bug. Pull Request resolved: pytorch#34357 Test Plan: - Existing tests for det and lu should pass Differential Revision: D20422879 Pulled By: seemethere fbshipit-source-id: 8dd7a30b5c31fc5b844e0a11965efd46067e936a
Summary: Changelog: - The magma implementation of small singular square batch matrices had a bug that resulted in nan values in the LU factorization result. This has been fixed in MAGMA 2.5.2. This PR removes the existing patch that was a temporary workaround for this bug. Pull Request resolved: pytorch#35973 Test Plan: - Existing tests for det and lu should pass This is a re-submit of pytorch#34357 Differential Revision: D21336552 Pulled By: seemethere fbshipit-source-id: 9c3b350966913147f1d5811927f3cae10fe620f1
Changelog:
Test Plan: