Skip to content

functional autograd api#34066

Closed
albanD wants to merge 13 commits intogh/albanD/39/basefrom
gh/albanD/39/head
Closed

functional autograd api#34066
albanD wants to merge 13 commits intogh/albanD/39/basefrom
gh/albanD/39/head

Conversation

@albanD
Copy link
Copy Markdown
Collaborator

@albanD albanD commented Mar 2, 2020 •
edited
Loading

Stack from ghstack:

Basic implementation of #30632

Differential Revision: D20260307

@albanD
functional autograd api
0929f2e 
[ghstack-poisoned]
@albanD albanD requested a review from apaszke as a code owner March 2, 2020 16:55
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 2, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 1a2a33b (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "Build" (full log | pattern match details)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py 
Auto-merging .circleci/cimodel/data/pytorch_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py 
Auto-merging .circleci/cimodel/data/dimensions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/caffe2_build_data.py 
Auto-merging .circleci/cimodel/data/caffe2_build_data.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_definitions.py 
Auto-merging .circleci/cimodel/data/binary_build_definitions.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_data.py 
Auto-merging .circleci/cimodel/data/binary_build_data.py 
Automatic merge failed; fix conflicts and then commit the result.

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_build (2/2)

Step: "Build" (full log | pattern match details)

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\algorithm(2749): error C2780: '_OutIt std::move(_InIt,_InIt,_OutIt)': expects 3 arguments - 1 provided 
        with
        [
            T=int64_t,
            _Ty=c10::IValue,
            _RanIt=c10::impl::ListIterator<int64_t,std::_Vector_iterator<std::_Vector_val<std::_Simple_types<c10::IValue>>>>
        ]
..\caffe2\operators\experimental\c10\cpu\expand_dims_cpu.cc(17): note: while compiling class template member function 'void caffe2::`anonymous-namespace'::expand_dims_cpu<float>::operator ()(const at::Tensor &,const at::Tensor &,c10::List<int64_t>)'
C:\Users\circleci\project\aten\src\ATen/core/boxing/kernel_functor.h(276): note: see reference to function template instantiation 'void caffe2::`anonymous-namespace'::expand_dims_cpu<float>::operator ()(const at::Tensor &,const at::Tensor &,c10::List<int64_t>)' being compiled
..\caffe2\operators\experimental\c10\cpu\expand_dims_cpu.cc(60): note: see reference to class template instantiation 'caffe2::`anonymous-namespace'::expand_dims_cpu<float>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\algorithm(2749): error C2672: 'std::move': no matching overloaded function found
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\algorithm(2749): error C2780: '_OutIt std::move(_InIt,_InIt,_OutIt)': expects 3 arguments - 1 provided
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.25.28610\include\xutility(3939): note: see declaration of 'std::move'
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28610.4 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /EHa /bigobj -DNDEBUG   -DCUDA_HAS_FP16=1 -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHa /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -O2 -DCAFFE2_BUILD_MAIN_LIB -DONNX_BUILD_MAIN_LIB -std:c++14 /showIncludes /Focaffe2\CMakeFiles\torch_cpu.dir\operators\experimental\c10\cpu\mul_cpu.cc.obj /Fdcaffe2\CMakeFiles\torch_cpu.dir\ /FS -c ..\caffe2\operators\experimental\c10\cpu\mul_cpu.cc 
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28610.4 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

DNDEBUG /w /EHa /bigobj -DNDEBUG   -DCUDA_HAS_FP16=1 -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHa /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -O2 -DCAFFE2_BUILD_MAIN_LIB -DONNX_BUILD_MAIN_LIB -std:c++14 /showIncludes /Focaffe2\CMakeFiles\torch_cpu.dir\operators\experimental\c10\cpu\sparse_lengths_sum_cpu.cc.obj /Fdcaffe2\CMakeFiles\torch_cpu.dir\ /FS -c ..\caffe2\operators\experimental\c10\cpu\sparse_lengths_sum_cpu.cc 
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28610.4 for x64
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 53 times.

albanD added a commit that referenced this pull request Mar 2, 2020
@albanD
functional autograd api
ce36b1d 
ghstack-source-id: 6b381f8
Pull Request resolved: #34066
@albanD albanD requested a review from zou3519 March 2, 2020 19:15
@albanD
Update on "functional autograd api"
9888c58 
Basic implementation of #30632

[ghstack-poisoned]
@albanD
Update on "functional autograd api"
3bb7e2e 
Basic implementation of #30632

[ghstack-poisoned]
albanD added a commit that referenced this pull request Mar 2, 2020
@albanD
functional autograd api
9037dc5 
ghstack-source-id: f950aba
Pull Request resolved: #34066
zou3519
zou3519 reviewed Mar 2, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread test/test_autograd.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread test/test_autograd.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread test/test_autograd.py
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
zou3519
zou3519 reviewed Mar 4, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
gchanan
gchanan reviewed Mar 16, 2020
View reviewed changes
Comment thread torch/autograd/functional.py Outdated
@albanD
Update on "functional autograd api"
7b96f24 
Basic implementation of #30632

Differential Revision: [D20260307](https://our.internmc.facebook.com/intern/diff/D20260307)

[ghstack-poisoned]
@albanD
Update on "functional autograd api"
5c503c5 
Basic implementation of #30632

Differential Revision: [D20260307](https://our.internmc.facebook.com/intern/diff/D20260307)

[ghstack-poisoned]
gchanan
gchanan reviewed Mar 17, 2020
View reviewed changes
Comment thread docs/source/autograd.rst
@albanD
Update on "functional autograd api"
fe4e73f 
Basic implementation of #30632

Differential Revision: [D20260307](https://our.internmc.facebook.com/intern/diff/D20260307)

[ghstack-poisoned]
albanD added a commit that referenced this pull request Mar 17, 2020
@albanD
functional autograd api
e1eafc1 
ghstack-source-id: 334f113
Pull Request resolved: #34066
zou3519
zou3519 approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

@albanD
Update on "functional autograd api"
1a2a33b 
Basic implementation of #30632

Differential Revision: [D20260307](https://our.internmc.facebook.com/intern/diff/D20260307)

[ghstack-poisoned]
albanD added a commit that referenced this pull request Mar 18, 2020
@albanD
functional autograd api
7ecb23a 
ghstack-source-id: 9d760fe
Pull Request resolved: #34066
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 19, 2020

@albanD merged this pull request in 1f4a4aa.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 19, 2020

@albanD merged this pull request in 1f4a4aa.

gchanan
gchanan reviewed Mar 20, 2020
View reviewed changes
Comment thread docs/source/autograd.rst
gchanan
gchanan reviewed Mar 20, 2020
View reviewed changes
Comment thread test/test_autograd.py
@facebook-github-bot facebook-github-bot deleted the gh/albanD/39/head branch March 23, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@albanD @facebook-github-bot
functional autograd api (pytorch#34066)
c88afff 
Summary:
Pull Request resolved: pytorch#34066

Basic implementation of pytorch#30632

Test Plan: Imported from OSS

Differential Revision: D20260307

Pulled By: albanD

fbshipit-source-id: 7db5c2411ddc3e954ff8fbbe93eb3b96a2bcfb2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan approved these changes

@zou3519 zou3519 zou3519 approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albanD @facebook-github-bot @gchanan @zou3519 @mruberry