Implement reduce keyword for SmoothL1Loss#3382
Merged
soumith merged 2 commits intopytorch:masterfrom Nov 1, 2017
Merged
Conversation
Contributor
Author
|
@pytorchbot retest this please |
apaszke
approved these changes
Oct 31, 2017
Contributor
apaszke
left a comment
There was a problem hiding this comment.
Looks good. Exactly the same comments as in the L1Loss PR.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
da97795 to
ff46126
Compare
fmassa
added a commit
to fmassa/pytorch
that referenced
this pull request
Mar 7, 2018
This has been present in master since pytorch#3382 but the doc for the functional interface was not taken into account.
ezyang
pushed a commit
that referenced
this pull request
Mar 7, 2018
This has been present in master since #3382 but the doc for the functional interface was not taken into account.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Implement reduce keyword for SmoothL1Loss
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
This has been present in master since pytorch#3382 but the doc for the functional interface was not taken into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #264. When reduce is False, SmoothL1Loss outputs a loss per element of the input tensor. When reduce is True (default), the current behavior is kept.
Test Plan
test/run_test.shAdded unit test for the reduce=False case. Also added a reference function to the reduce=True unit test.