Skip to content

[Lite Interpreter] Serialize/deserialize/run __setstate__#33295

Closed
iseeyuan wants to merge 6 commits intogh/iseeyuan/48/basefrom
gh/iseeyuan/48/head
Closed

[Lite Interpreter] Serialize/deserialize/run __setstate__#33295
iseeyuan wants to merge 6 commits intogh/iseeyuan/48/basefrom
gh/iseeyuan/48/head

Conversation

@iseeyuan
Copy link
Copy Markdown
Contributor

@iseeyuan iseeyuan commented Feb 13, 2020 •
edited
Loading

Stack from ghstack:

@iseeyuan iseeyuan requested a review from apaszke as a code owner February 13, 2020 16:19
@iseeyuan iseeyuan mentioned this pull request Feb 13, 2020
Closed
iseeyuan pushed a commit that referenced this pull request Feb 13, 2020
[Lite Interpreter] Serialize/deserialize __setstate__
922c41a 
ghstack-source-id: e256606
Pull Request resolved: #33295
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 13, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Feb 13, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 040a75b:

None of the build failures appear to be your fault.

  • 1/1 broken upstream at merge base 02908df since Feb 26

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
git rebase --onto viable/strict $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 27 times.

iseeyuan pushed a commit that referenced this pull request Feb 13, 2020
[Lite Interpreter] Serialize/deserialize __setstate__
c4cfb5d 
ghstack-source-id: 31db0a7
Pull Request resolved: #33295
@iseeyuan iseeyuan changed the title [Lite Interpreter] Serialize/deserialize __setstate__ [Lite Interpreter] Serialize/deserialize/run __setstate__ Feb 13, 2020
dzhulgakov
dzhulgakov reviewed Feb 14, 2020
View reviewed changes
Comment thread aten/src/ATen/native/quantized/cpu/qlinear_prepack.cpp
.op("quantized::linear_prepack_fp16(Tensor W, Tensor? B=None) -> Tensor W_prepack",
c10::RegisterOperators::options().kernel<QLinearPackWeightFp16>(
DispatchKey::CPUTensorId))
.op("_quantized::linear_prepack(Tensor W, Tensor? B=None) -> Tensor W_prepack",
Copy link
Copy Markdown
Collaborator

@dzhulgakov dzhulgakov Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to register these ops twice?

Copy link
Copy Markdown
Contributor Author

@iseeyuan iseeyuan Feb 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a temporary solution and will be removed. Currently all lite interpreter ops are prefixed with "" because the same ops may be already registered in JIT that were not searchable from lite interpreter. To make them build together for unit tests we have this naming hack cc @smessmer . The "" will be removed after we have all ops searchable.

@jamesr66a
Copy link
Copy Markdown
Collaborator

jamesr66a commented Feb 25, 2020

The logic around setstate looks reasonable to me!

iseeyuan pushed a commit that referenced this pull request Feb 25, 2020
[Lite Interpreter] Serialize/deserialize __setstate__
a94ec35 
ghstack-source-id: 2a52dde
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Feb 25, 2020
[Lite Interpreter] Serialize/deserialize __setstate__
142993c 
ghstack-source-id: 8f243fc
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Feb 26, 2020
[Lite Interpreter] Serialize/deserialize __setstate__
0e113cc 
ghstack-source-id: cb50b33
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Feb 27, 2020
register ops for quantized linear.
7a7c1dd 
ghstack-source-id: 351e4ec
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: 351e4ec
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Feb 29, 2020
register ops for quantized linear.
4852126 
ghstack-source-id: 646caa4
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: 646caa4
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Mar 2, 2020
register ops for quantized linear.
b376752 
ghstack-source-id: ae93780
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: ae93780
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Mar 2, 2020
register ops for quantized linear.
e370643 
ghstack-source-id: 21a1969
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: 21a1969
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Mar 3, 2020
register ops for quantized linear.
1043b00 
ghstack-source-id: 1b08abf
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: 1b08abf
Pull Request resolved: #33295
iseeyuan pushed a commit that referenced this pull request Mar 5, 2020
register ops for quantized linear.
246c4fe 
ghstack-source-id: a9e159b
Pull Request resolved: #33294

[Lite Interpreter] Serialize/deserialize __setstate__

ghstack-source-id: a9e159b
Pull Request resolved: #33295
@pytorchbot
Copy link
Copy Markdown
Collaborator

pytorchbot commented Apr 12, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions Bot closed this May 12, 2022
@facebook-github-bot facebook-github-bot deleted the gh/iseeyuan/48/head branch June 11, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzhulgakov dzhulgakov dzhulgakov left review comments

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iseeyuan @jamesr66a @pytorchbot @dzhulgakov @facebook-github-bot