Use torch.set_default_dtype in test_data_parallel and rename dtype2prec#32962
Closed
pritamdamania87 wants to merge 2 commits intogh/pritamdamania87/94/basefrom
Closed
Use torch.set_default_dtype in test_data_parallel and rename dtype2prec#32962pritamdamania87 wants to merge 2 commits intogh/pritamdamania87/94/basefrom
pritamdamania87 wants to merge 2 commits intogh/pritamdamania87/94/basefrom
Conversation
As per @gchanan's comments on #30445, I've used `torch.set_default_dtype` in test_data_parallel instead of specifying dtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE Differential Revision: [D19714374](https://our.internmc.facebook.com/intern/diff/D19714374/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Feb 4, 2020
As per @gchanan's comments on #30445, I've used `torch.set_default_dtype` in test_data_parallel instead of specifying dtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE Differential Revision: [D19714374](https://our.internmc.facebook.com/intern/diff/D19714374/) ghstack-source-id: 97676959 Pull Request resolved: #32962
gchanan
reviewed
Feb 7, 2020
|
|
||
| dtype2prec = {torch.float: 1e-5, | ||
| # Using @precisionOverride is the recommended way instead of this. | ||
| dtype2prec_DONTUSE = {torch.float: 1e-5, |
gchanan
reviewed
Feb 7, 2020
|
|
||
|
|
||
| dtype2prec = {torch.float: 1e-5, | ||
| # Using @precisionOverride is the recommended way instead of this. |
Contributor
There was a problem hiding this comment.
maybe add a bit more context: using precisionOverride specific to your test is the recommended way of doing this. These are just some values that worked for test_nn.
gchanan
approved these changes
Feb 7, 2020
Contributor
gchanan
left a comment
There was a problem hiding this comment.
address the comments then looks good to go.
…me dtype2prec" As per @gchanan's comments on #30445, I've used `torch.set_default_dtype` in test_data_parallel instead of specifying dtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE Differential Revision: [D19714374](https://our.internmc.facebook.com/intern/diff/D19714374/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Feb 15, 2020
Pull Request resolved: #32962 As per @gchanan's comments on #30445, I've used `torch.set_default_dtype` in test_data_parallel instead of specifying dtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE ghstack-source-id: 98388429 Differential Revision: [D19714374](https://our.internmc.facebook.com/intern/diff/D19714374/)
💊 CircleCI build failures summary and remediationsAs of commit e095808: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🚧 3 upstream failures recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
Contributor
|
This pull request has been merged in fd684cc. |
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…ec (pytorch#32962) Summary: Pull Request resolved: pytorch#32962 As per gchanan's comments on pytorch#30445, I've used `torch.set_default_dtype` in test_data_parallel instead of specifying dtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE ghstack-source-id: 98388429 Test Plan: waitforbuildbot Differential Revision: D19714374 fbshipit-source-id: eb55bbca33881625636ba9ea6dd4cb692f25668e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As per @gchanan's comments on
#30445, I've used
torch.set_default_dtypein test_data_parallel instead of specifyingdtype=torch.double everywhere. Also, renamed dtype2prec to dtype2prec_DONTUSE
Differential Revision: D19714374