[Pytorch] Propagate errors in clearAndWaitForOutstandingRpcsAsync.#32952
Closed
jjlilley wants to merge 1 commit intogh/jjlilley/48/basefrom
Closed
[Pytorch] Propagate errors in clearAndWaitForOutstandingRpcsAsync.#32952jjlilley wants to merge 1 commit intogh/jjlilley/48/basefrom
jjlilley wants to merge 1 commit intogh/jjlilley/48/basefrom
Conversation
When the Async() version of clearAndWaitForOutstandingRpcs() was written, we didn't yet have the generic Future<T> class, and hadn't worked out our error model fully. This change fixes that method to properly propagate the first encountered error to the future, using a bool+CAS. Differential Revision: [D19710337](https://our.internmc.facebook.com/intern/diff/D19710337/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
Feb 4, 2020
When the Async() version of clearAndWaitForOutstandingRpcs() was written, we didn't yet have the generic Future<T> class, and hadn't worked out our error model fully. This change fixes that method to properly propagate the first encountered error to the future, using a bool+CAS. Differential Revision: [D19710337](https://our.internmc.facebook.com/intern/diff/D19710337/) ghstack-source-id: 97665749 Pull Request resolved: #32952
pritamdamania87
approved these changes
Feb 4, 2020
Contributor
pritamdamania87
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Contributor
|
This pull request has been merged in b894dc0. |
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
…ytorch#32952) Summary: Pull Request resolved: pytorch#32952 When the Async() version of clearAndWaitForOutstandingRpcs() was written, we didn't yet have the generic Future<T> class, and hadn't worked out our error model fully. This change fixes that method to properly propagate the first encountered error to the future, using a bool+CAS. ghstack-source-id: 97665749 Test Plan: existing test coverage, buck test mode/dev-nosan caffe2/test/... Differential Revision: D19710337 fbshipit-source-id: 66ce5593a94a16ea624930dbb9409917ef5cfd5d
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…ytorch#32952) Summary: Pull Request resolved: pytorch#32952 When the Async() version of clearAndWaitForOutstandingRpcs() was written, we didn't yet have the generic Future<T> class, and hadn't worked out our error model fully. This change fixes that method to properly propagate the first encountered error to the future, using a bool+CAS. ghstack-source-id: 97665749 Test Plan: existing test coverage, buck test mode/dev-nosan caffe2/test/... Differential Revision: D19710337 fbshipit-source-id: 66ce5593a94a16ea624930dbb9409917ef5cfd5d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
When the Async() version of clearAndWaitForOutstandingRpcs() was written,
we didn't yet have the generic Future class, and hadn't worked out our
error model fully.
This change fixes that method to properly propagate the first encountered error
to the future, using a bool+CAS.
Differential Revision: D19710337