ONNX Update training ops and training amenable export API by lara-hdr · Pull Request #32950 · pytorch/pytorch

lara-hdr · 2020-02-03T23:39:01Z

Update Dropout and Batchnorm in opset 12 : Update Dropout and BatchNorm to be Training Friendly onnx/onnx#2568
Update api logic for exporting to ONNX training amenable models

kostmo · 2020-02-03T23:42:55Z

💊 CircleCI build failures summary and remediations

As of commit bf610bf (more details on the Dr. CI page):

2/3 failures introduced in this PR
1/3 broken upstream at merge base bfdcc39 from Mar 23 until Mar 24 (47 commits; 77ccb5c - 3f896ef)
Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:
```
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
```
Check out the recency history of this "viable master" tracking branch.

🕵️ 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 1 job to discount flakiness):

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "Build" (full log | pattern match details) <confirmed not flaky by 2 failures>

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in CMakeLists.txt 
Auto-merging CMakeLists.txt 
CONFLICT (add/add): Merge conflict in .jenkins/pytorch/win-test-helpers/build_pytorch.bat 
Auto-merging .jenkins/pytorch/win-test-helpers/build_pytorch.bat 
CONFLICT (add/add): Merge conflict in .jenkins/pytorch/macos-common.sh 
Auto-merging .jenkins/pytorch/macos-common.sh 
CONFLICT (add/add): Merge conflict in .github/workflows/lint.yml 
Auto-merging .github/workflows/lint.yml 
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_populate_env.sh 
Auto-merging .circleci/scripts/binary_populate_env.sh 
Automatic merge failed; fix conflicts and then commit the result.

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 27 05:26:23 AssertionError: 11 not less than or equal to 1e-05 :

Mar 27 05:26:23 ---------------------------------------------------------------------- 
Mar 27 05:26:23 Traceback (most recent call last): 
Mar 27 05:26:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 27 05:26:23     self._join_processes(fn) 
Mar 27 05:26:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 27 05:26:23     self._check_return_codes(elapsed_time) 
Mar 27 05:26:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 27 05:26:23     self.assertEqual(first_process.exitcode, 0) 
Mar 27 05:26:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 27 05:26:23     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 27 05:26:23 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 27 05:26:23  
Mar 27 05:26:23 ---------------------------------------------------------------------- 
Mar 27 05:26:23 Ran 29 tests in 23.055s 
Mar 27 05:26:23  
Mar 27 05:26:23 FAILED (failures=1) 
Mar 27 05:26:23  
Mar 27 05:26:23 Generating XML reports... 
Mar 27 05:26:23 Traceback (most recent call last): 
Mar 27 05:26:23   File "test/run_test.py", line 682, in <module> 
Mar 27 05:26:23     main()

1 job timed out:

pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 153 times.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…ining

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad

Could you rebase to master and trigger the test again?

…ining

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad · 2020-03-17T16:23:04Z

https://github.com/pytorch/pytorch/pull/32950/checks?check_run_id=512600263 clang-tidy is broken, could you fix it?

lara-hdr · 2020-03-18T20:09:12Z

@houseroad it seems like after adding the "Training" enum in torch/csrc/onnx/init.cpp, clang-tidy is trying to include onnx-ml.pb.h (instead of onnx.ph.h) which is the reason of the failure.

I am not sure why this is happening since ONNX_ML is not defined..
https://github.com/onnx/onnx/blob/9fdae4c68960a2d44cd1cc871c74a6a9d469fa1f/onnx/onnx_pb.h#L50

This reverts commit 4f0b292.

…aidar/onnx_training

lara-hdr · 2020-03-24T19:41:11Z

            -g"-torch/csrc/jit/export.cpp"            \
            -g"-torch/csrc/jit/import.cpp"            \
            -g"-torch/csrc/jit/netdef_converter.cpp"  \
+            -g"-torch/csrc/onnx/init.cpp"             \


@houseroad added this line to exclude init.cpp (which includes onnx_pb.h) to fix the linter error, as explained in the comment above (line 191-193)

lara-hdr · 2020-03-24T21:11:13Z

cc @houseroad clang-tidy issue is fixed

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-03-27T12:24:36Z

@houseroad merged this pull request in 025a0ab.

) Summary: - Update Dropout and Batchnorm in opset 12 : onnx/onnx#2568 - Update api logic for exporting to ONNX training amenable models Pull Request resolved: pytorch#32950 Reviewed By: hl475 Differential Revision: D19710370 Pulled By: houseroad fbshipit-source-id: e5e79d38552936966662c41d39ddf33be1ba3e35

Lara added 4 commits February 3, 2020 14:21

update training ops and export training api

dafeeb2

mend

0d58539

merge and resolve conflicts

c2e16c5

update tests

55f4692

lara-hdr commented Feb 3, 2020

View reviewed changes

Comment thread torch/onnx/symbolic_opset12.py

lara-hdr commented Feb 3, 2020

View reviewed changes

Comment thread torch/onnx/utils.py

update doc

9ba9bf5

pytorchbot added the open source label Feb 3, 2020

rever 3rd-p

f0a5080

lara-hdr requested review from BowenBao and houseroad February 3, 2020 23:54

facebook-github-bot reviewed Feb 4, 2020

View reviewed changes

jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 5, 2020

fix scriptfunction

a3b6025

facebook-github-bot reviewed Feb 7, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into lahaidar/onnx_tra…

60d2a2a

…ining

facebook-github-bot reviewed Feb 12, 2020

View reviewed changes

facebook-github-bot reviewed Feb 16, 2020

View reviewed changes

Lara added 4 commits February 19, 2020 13:58

rebase

b051585

lint

bf17dd4

fix ci

e6824ac

rebase

49eb5d0

spandantiwari reviewed Feb 20, 2020

View reviewed changes

Comment thread torch/onnx/symbolic_helper.py

spandantiwari reviewed Feb 20, 2020

View reviewed changes

Comment thread torch/onnx/utils.py Outdated

spandantiwari reviewed Feb 20, 2020

View reviewed changes

Comment thread torch/onnx/utils.py

spandantiwari reviewed Feb 20, 2020

View reviewed changes

Comment thread torch/onnx/utils.py Outdated

spandantiwari reviewed Feb 20, 2020

View reviewed changes

Comment thread torch/onnx/utils.py

facebook-github-bot reviewed Feb 21, 2020

View reviewed changes

spandantiwari reviewed Feb 21, 2020

View reviewed changes

Comment thread torch/onnx/symbolic_opset12.py

BowenBao reviewed Mar 13, 2020

View reviewed changes

Comment thread torch/onnx/utils.py Outdated

BowenBao reviewed Mar 13, 2020

View reviewed changes

Comment thread torch/onnx/symbolic_helper.py Outdated

BowenBao reviewed Mar 13, 2020

View reviewed changes

Comment thread torch/onnx/utils.py

BowenBao reviewed Mar 13, 2020

View reviewed changes

Comment thread torch/onnx/utils.py Outdated

improve warning; remove unused fct param

c51d716

BowenBao approved these changes Mar 16, 2020

View reviewed changes

houseroad reviewed Mar 17, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into lahaidar/onnx_tra…

4c7167c

…ining

facebook-github-bot reviewed Mar 17, 2020

View reviewed changes

lara-hdr added 6 commits March 23, 2020 13:14

test clang-tidy

4f0b292

Revert "test clang-tidy"

a6eba8e

This reverts commit 4f0b292.

test cland-tiy

b1e3a59

Update lint.yml

9bef9e2

Merge branch 'master' of https://github.com/lara-hdr/pytorch into lah…

d9bf222

…aidar/onnx_training

update expect file producer nb

36b23a6

lara-hdr commented Mar 24, 2020

View reviewed changes

facebook-github-bot reviewed Mar 25, 2020

View reviewed changes

update deflt

bf610bf

facebook-github-bot reviewed Mar 27, 2020

View reviewed changes

facebook-github-bot closed this in 025a0ab Mar 27, 2020

facebook-github-bot added the merged label Mar 27, 2020

mruberry added the Merged label Oct 28, 2020

Conversation

lara-hdr commented Feb 3, 2020

Uh oh!

Uh oh!

kostmo commented Feb 3, 2020 • edited by dr-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Uh oh!

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

houseroad left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houseroad commented Mar 17, 2020

Uh oh!

lara-hdr commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lara-hdr Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

lara-hdr commented Mar 24, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

kostmo commented Feb 3, 2020 •

edited by dr-ci Bot

Loading

lara-hdr commented Mar 18, 2020 •

edited

Loading