Skip to content

Clarify when softplus is reverted to linear.#32945

Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:doc/softplus
Closed

Clarify when softplus is reverted to linear.#32945
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:doc/softplus

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Feb 3, 2020

The default value is removed because it is explained right below.

@xuhdev xuhdev requested a review from ssnl February 3, 2020 22:12
@xuhdev xuhdev requested a review from apaszke as a code owner February 3, 2020 22:13
@xuhdev xuhdev requested review from ailzhang and soumith February 3, 2020 22:13
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kostmo
Copy link
Member

kostmo commented Feb 3, 2020

💊 CircleCI build failures summary and remediations

As of commit 0158e02:

  • 1/1 failures introduced in this PR

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakage:

See CircleCI build pytorch_windows_test2 (1/1)

Step: "Test" (full log | pattern match details)

RuntimeError: test_cuda failed!
 
---------------------------------------------------------------------- 
Ran 98 tests in 44.548s 
 
FAILED (failures=1, skipped=48) 
Traceback (most recent call last): 
  File "run_test.py", line 457, in <module> 
    main() 
  File "run_test.py", line 450, in main 
    raise RuntimeError(message) 
RuntimeError: test_cuda failed! 
 
(base) circleci@PACKER-5E29F737 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in 3cac990.

@facebook-github-bot
Copy link
Contributor

@ailzhang merged this pull request in 3cac990.

BowenBao pushed a commit to BowenBao/pytorch that referenced this pull request Feb 12, 2020
Summary:
The default value is removed because it is explained right below.
Pull Request resolved: pytorch#32945

Reviewed By: soumith

Differential Revision: D19706567

Pulled By: ailzhang

fbshipit-source-id: 1b7cc87991532f69b81aaae2451d944f70dda427
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary:
The default value is removed because it is explained right below.
Pull Request resolved: pytorch#32945

Reviewed By: soumith

Differential Revision: D19706567

Pulled By: ailzhang

fbshipit-source-id: 1b7cc87991532f69b81aaae2451d944f70dda427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants