properly update _flat_weights in RNN modules#32939
Closed
ngimel wants to merge 2 commits intopytorch:masterfrom
Closed
properly update _flat_weights in RNN modules#32939ngimel wants to merge 2 commits intopytorch:masterfrom
ngimel wants to merge 2 commits intopytorch:masterfrom
Conversation
mruberry
reviewed
Feb 3, 2020
| # does not throw an error | ||
| m.cuda() | ||
| # recompute the weight and make sure that module can be used | ||
| setattr(m, "weight_hh_l0", weight_orig.cuda()) |
Collaborator
There was a problem hiding this comment.
m.weight_hh_l0 = weight_orig.cuda()
mruberry
approved these changes
Feb 3, 2020
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Looks better than before!
Member
💊 CircleCI build failures summary and remediationsAs of commit 9a18f36: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. ❄️ 1 failure recognized as flakyThe following build failures have been detected as flaky and may not be your fault:
|
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
ngimel
pushed a commit
to ngimel/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Should fix pytorch#32346 hopefully. Now when _flat_weights list is updated, `None` elements are appended to it if some weights are missing, subsequent `setattr` calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: pytorch#32939 Differential Revision: D19710990 Pulled By: ngimel fbshipit-source-id: c978c7519464e94beeffa9bc33b9172854a2f298
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 5, 2020
Summary: Resubmitting #32939 Should fix #32346 hopefully. Now when _flat_weights list is updated, None elements are appended to it if some weights are missing, subsequent setattr calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: #32989 Differential Revision: D19731952 Pulled By: ngimel fbshipit-source-id: 2118a19840491e7ab0fef15185fad982f42795a6
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: Should fix pytorch#32346 hopefully. Now when _flat_weights list is updated, `None` elements are appended to it if some weights are missing, subsequent `setattr` calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: pytorch#32939 Differential Revision: D19710990 Pulled By: ngimel fbshipit-source-id: c978c7519464e94beeffa9bc33b9172854a2f298
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: Resubmitting pytorch#32939 Should fix pytorch#32346 hopefully. Now when _flat_weights list is updated, None elements are appended to it if some weights are missing, subsequent setattr calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: pytorch#32989 Differential Revision: D19731952 Pulled By: ngimel fbshipit-source-id: 2118a19840491e7ab0fef15185fad982f42795a6
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Should fix pytorch#32346 hopefully. Now when _flat_weights list is updated, `None` elements are appended to it if some weights are missing, subsequent `setattr` calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: pytorch#32939 Differential Revision: D19710990 Pulled By: ngimel fbshipit-source-id: c978c7519464e94beeffa9bc33b9172854a2f298
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Resubmitting pytorch#32939 Should fix pytorch#32346 hopefully. Now when _flat_weights list is updated, None elements are appended to it if some weights are missing, subsequent setattr calls for the missing weights should repair _flat_weights and make it suitable to use in the backend. Pull Request resolved: pytorch#32989 Differential Revision: D19731952 Pulled By: ngimel fbshipit-source-id: 2118a19840491e7ab0fef15185fad982f42795a6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #32346 hopefully. Now when _flat_weights list is updated,
Noneelements are appended to it if some weights are missing, subsequentsetattrcalls for the missing weights should repair _flat_weights and make it suitable to use in the backend.