min, max: check that operand and outputs are on the same device type#32862
min, max: check that operand and outputs are on the same device type#32862Baranowski wants to merge 4 commits intopytorch:masterfrom
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 1061b8d: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🚧 1 upstream failure recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
| TORCH_CHECK(self.layout() == Layout::Strided, | ||
| "max only supports strided layout, got: ", self.layout()); | ||
| TORCH_CHECK(self.device().type() == max.device().type(), | ||
| "expected device type ", self.device().type(), " but got ", |
There was a problem hiding this comment.
You should just check that the device() are equal, as mixed-device operations won't work on this kernel anyway
ezyang
left a comment
There was a problem hiding this comment.
LGTM, but let's test device()
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ytorch#32862) Summary: Fixes pytorch#32001 Pull Request resolved: pytorch#32862 Differential Revision: D19695935 Pulled By: ezyang fbshipit-source-id: bb37eb7a187214aa69259828024366f479a258d7
…ytorch#32862) Summary: Fixes pytorch#32001 Pull Request resolved: pytorch#32862 Differential Revision: D19695935 Pulled By: ezyang fbshipit-source-id: bb37eb7a187214aa69259828024366f479a258d7
Fixes #32001