Emit the C++ version when compiling pytorch from source.#32819
Closed
v0dro wants to merge 1 commit intopytorch:masterfrom
Closed
Emit the C++ version when compiling pytorch from source.#32819v0dro wants to merge 1 commit intopytorch:masterfrom
v0dro wants to merge 1 commit intopytorch:masterfrom
Conversation
Member
💊 CircleCI build failures summary and remediationsAs of commit 73e31dd: None of the build failures appear to be your fault.
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🚧 2 upstream failures recognized by patterns:These builds matched patterns, but were probably caused by upstream breakages:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: The need for this is felt because sometimes we change a build script and change the `std=c++XX` flag, which does not get caught until the compilation has progressed for a while. pytorch#31757 Pull Request resolved: pytorch#32819 Differential Revision: D19697205 Pulled By: ezyang fbshipit-source-id: b045a1d15e24c4c6007b5d1464756051d32bf911
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: The need for this is felt because sometimes we change a build script and change the `std=c++XX` flag, which does not get caught until the compilation has progressed for a while. pytorch#31757 Pull Request resolved: pytorch#32819 Differential Revision: D19697205 Pulled By: ezyang fbshipit-source-id: b045a1d15e24c4c6007b5d1464756051d32bf911
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The need for this is felt because sometimes we change a build script and change the
std=c++XXflag, which does not get caught until the compilation has progressed for a while.#31757