Skip to content

[ONNX] Update ONNX landing page since 1.3#32805

Closed
BowenBao wants to merge 3 commits intopytorch:masterfrom
BowenBao:onnx_1_4_doc
Closed

[ONNX] Update ONNX landing page since 1.3#32805
BowenBao wants to merge 3 commits intopytorch:masterfrom
BowenBao:onnx_1_4_doc

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jan 30, 2020

  • New ops supported for exporting.
  • Updates on support for tensor indexing and dynamic list of tensors.
  • @lara-hdr, @spandantiwari Should we also include updates on torchvision support in this page?

cc @houseroad, @neginraoof Please review if I have missed anything.

facebook-github-bot
facebook-github-bot reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad reviewed Jan 30, 2020
View reviewed changes
docs/source/onnx.rst Outdated

Q: Is tensor list exportable to ONNX?

Yes, this is supported now for ONNX opset version >= 11. E.g.: ::
Copy link
Member

@houseroad houseroad Jan 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mention how we express tensor list in ONNX?

@kostmo
Copy link
Member

kostmo commented Jan 30, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit c728502:

None of the build failures appear to be your fault.

  • 1/1 recognized as flaky ❄️
    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 1 failure recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build pytorch_linux_xenial_cuda10_1_cudnn7_py3_nogpu_test (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | pattern match details) ❄️

E: Failed to fetch https://nvidia.github.io/nvidia-container-runtime/ubuntu16.04/amd64/./nvidia-container-runtime_2.0.0+docker18.09.4-1_amd64.deb GnuTLS recv error (-54): Error in the pull function. 
                                                                   91% [Working]               Get:26 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 intel-microcode amd64 3.20191115.1ubuntu0.16.04.2 [2,408 kB] 
91% [26 intel-microcode 64.1 kB/2,408 kB 3%] 94% [Working]                                                      21.3 MB/s 0s                                                                                 Get:27 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 amd64-microcode amd64 3.20191021.1+really3.20180524.1~ubuntu0.16.04.2 [30.8 kB] 
94% [27 amd64-microcode 23.5 kB/30.8 kB 76%]                       21.3 MB/s 0s 94% [Working]                                                      21.3 MB/s 0s                                                                                 Get:28 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 linux-image-generic amd64 4.4.0.173.181 [2,486 B] 
94% [28 linux-image-generic 2,486 B/2,486 B 100%]                  21.3 MB/s 0s 95% [Working]                                                      21.3 MB/s 0s                                                                                 Get:29 http://archive.ubuntu.com/ubuntu xenial/universe amd64 moreutils amd64 0.57-1 [55.0 kB] 
95% [29 moreutils 2,535 B/55.0 kB 5%]                              21.3 MB/s 0s 95% [Working]                                                      21.3 MB/s 0s                                                                                 Get:30 http://archive.ubuntu.com/ubuntu xenial/main amd64 tcl8.6 amd64 8.6.5+dfsg-2 [14.2 kB] 
95% [30 tcl8.6 2,535 B/14.2 kB 18%]                                21.3 MB/s 0s 96% [Working]                                                      21.3 MB/s 0s                                                                                 Get:31 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 thermald amd64 1.5-2ubuntu4 [187 kB] 
96% [31 thermald 2,533 B/187 kB 1%]                                21.3 MB/s 0s 97% [Working]                                                      21.3 MB/s 0s                                                                                 Get:32 http://archive.ubuntu.com/ubuntu xenial/main amd64 tk8.6 amd64 8.6.5-1 [12.2 kB] 
97% [32 tk8.6 2,535 B/12.2 kB 21%]                                 21.3 MB/s 0s 97% [Working]                                                      21.3 MB/s 0s                                                                                 Get:33 http://archive.ubuntu.com/ubuntu xenial/main amd64 xterm amd64 322-1ubuntu1 [607 kB] 
97% [33 xterm 2,533 B/607 kB 0%]                                   21.3 MB/s 0s 98% [Working]                                                      21.3 MB/s 0s                                                                                 Fetched 129 MB in 7s (17.8 MB/s) 
W: --force-yes is deprecated, use one of the options starting with --allow instead. 
E: Failed to fetch https://nvidia.github.io/nvidia-container-runtime/ubuntu16.04/amd64/./nvidia-container-runtime_2.0.0+docker18.09.4-1_amd64.deb  GnuTLS recv error (-54): Error in the pull function. 
 
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 4 times.

@vincentqb vincentqb added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 30, 2020
lara-hdr
lara-hdr approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@lara-hdr lara-hdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

facebook-github-bot
facebook-github-bot reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 3, 2020

@houseroad merged this pull request in 1018306.

BowenBao added a commit to BowenBao/pytorch that referenced this pull request Feb 12, 2020
@BowenBao
[ONNX] Update ONNX landing page since 1.3 (pytorch#32805)
46623be 
Summary:
* New ops supported for exporting.
* Updates on support for tensor indexing and dynamic list of tensors.
* lara-hdr, spandantiwari Should we also include updates on torchvision support in this page?

cc houseroad, neginraoof Please review if I have missed anything.
Pull Request resolved: pytorch#32805

Reviewed By: hl475

Differential Revision: D19635699

Pulled By: houseroad

fbshipit-source-id: b6be4fce641f852dcbceed20b4433f4037d8024a
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
@BowenBao @ttumiel
[ONNX] Update ONNX landing page since 1.3 (pytorch#32805)
d55a660 
Summary:
* New ops supported for exporting.
* Updates on support for tensor indexing and dynamic list of tensors.
* lara-hdr, spandantiwari Should we also include updates on torchvision support in this page?

cc houseroad, neginraoof Please review if I have missed anything.
Pull Request resolved: pytorch#32805

Reviewed By: hl475

Differential Revision: D19635699

Pulled By: houseroad

fbshipit-source-id: b6be4fce641f852dcbceed20b4433f4037d8024a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

+2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@lara-hdr lara-hdr lara-hdr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BowenBao @kostmo @facebook-github-bot @lara-hdr @houseroad @vincentqb @pytorchbot @mruberry