[ONNX] Add einsum export by neginraoof · Pull Request #32716 · pytorch/pytorch

neginraoof · 2020-01-28T19:34:08Z

Adding symbolic for onnx einsum as part of opset 12

kostmo · 2020-01-28T20:00:52Z

💊 CircleCI build failures summary and remediations

As of commit ad32141:

None of the build failures appear to be your fault.

2/2 broken upstream at merge base 0dc38be since Jan 28
Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:
```
git fetch origin viable/strict
git rebase viable/strict
```
Check out the recency history of this "viable master" tracking branch.

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🚧 2 upstream failures recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX2_test from Jan 28 until Jan 28
pytorch_macos_10_13_py3_test from Jan 28 until Jan 28

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 9 times.

yf225 · 2020-01-29T19:42:12Z

@houseroad Please let me know if I should ask someone else to review it. Thanks!

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad

Looks good, thanks.

houseroad · 2020-01-30T02:34:26Z

torch/onnx/symbolic_opset12.py

+
+@parse_args('s', 'v')
+def einsum(g, equation, tensor_list):
+    return g.op("Einsum", tensor_list, equation_s=equation)


How do we handle tensor_list here?

Thanks, I missed that. I fixed the symbolic and checked on onnx graph.

test/onnx/test_pytorch_onnx_onnxruntime.py

houseroad

Actually, tests are failing. Is it related?

…into neraoof/einsum

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

neginraoof · 2020-01-31T21:09:24Z

Actually, tests are failing. Is it related?
@houseroad Thanks.
Torchvision tests failed for ORT backend opset 12 tests. This is beacuse torchvision custom ops are registered as part of opset 11 only. I'll disabled those tests for opset 12. I'm going to send a fix for this in another PR.

facebook-github-bot

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-02-03T22:13:37Z

@houseroad merged this pull request in e03e4f3.

Summary: Adding symbolic for onnx einsum as part of opset 12 Pull Request resolved: pytorch#32716 Reviewed By: hl475 Differential Revision: D19626168 Pulled By: houseroad fbshipit-source-id: d8cc8af5f05f36aca3cd55dead602261ccdfec51

tygrer · 2020-03-19T09:02:08Z

I still cannot convert model from pytorch to onnx. Even though I has altered the source code of
symbolic_opset12.py and symbolic_helper.py. The op of einsum is still not be recognized.
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/init.py", line 148, in export
strip_doc_string, dynamic_axes, keep_initializers_as_inputs)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/utils.py", line 66, in export
dynamic_axes=dynamic_axes, keep_initializers_as_inputs=keep_initializers_as_inputs)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/utils.py", line 416, in _export
fixed_batch_size=fixed_batch_size)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/utils.py", line 296, in _model_to_graph
fixed_batch_size=fixed_batch_size, params_dict=params_dict)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/utils.py", line 135, in _optimize_graph
graph = torch._C._jit_pass_onnx(graph, operator_export_type)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/init.py", line 179, in _run_symbolic_function
return utils._run_symbolic_function(*args, **kwargs)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/utils.py", line 656, in _run_symbolic_function
op_fn = sym_registry.get_registered_op(op_name, '', opset_version)
File "/home/tanggy/anaconda3/envs/grab/lib/python3.6/site-packages/torch/onnx/symbolic_registry.py", line 91, in get_registered_op
return _registry[(domain, version)][opname]
KeyError: 'einsum

neginraoof added 3 commits January 28, 2020 10:14

added symbolic for onnx einsum export

d05b9f3

fix for lists

abed694

fix for lists

5363f7e

pytorchbot added the open source label Jan 28, 2020

skip

81701c0

yf225 requested a review from houseroad January 29, 2020 19:41

facebook-github-bot reviewed Jan 29, 2020

View reviewed changes

yf225 added module: onnx Related to torch.onnx triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 29, 2020

houseroad approved these changes Jan 30, 2020

View reviewed changes

houseroad requested review from BowenBao, lara-hdr and spandantiwari January 30, 2020 02:35

houseroad reviewed Jan 30, 2020

View reviewed changes

neginraoof added 2 commits January 31, 2020 10:24

fix for feedback

3c36fb0

Merge branch 'neraoof/einsum' of https://github.com/neginraoof/pytorch …

ad32141

…into neraoof/einsum

facebook-github-bot reviewed Jan 31, 2020

View reviewed changes

facebook-github-bot reviewed Feb 3, 2020

View reviewed changes

facebook-github-bot closed this in e03e4f3 Feb 3, 2020

facebook-github-bot added the merged label Feb 3, 2020

spandantiwari mentioned this pull request Feb 19, 2020

onnx export: einsum not supported #26893

Closed

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Add einsum export#32716

[ONNX] Add einsum export#32716
neginraoof wants to merge 6 commits intopytorch:masterfrom
neginraoof:neraoof/einsum

neginraoof commented Jan 28, 2020

Uh oh!

kostmo commented Jan 28, 2020 •

edited

Loading

Uh oh!

yf225 commented Jan 29, 2020

Uh oh!

facebook-github-bot left a comment

Uh oh!

houseroad left a comment

Uh oh!

houseroad Jan 30, 2020

Uh oh!

neginraoof Jan 31, 2020

Uh oh!

Uh oh!

houseroad left a comment

Uh oh!

facebook-github-bot left a comment

Uh oh!

neginraoof commented Jan 31, 2020

Uh oh!

facebook-github-bot left a comment

Uh oh!

facebook-github-bot commented Feb 3, 2020

Uh oh!

tygrer commented Mar 19, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

neginraoof commented Jan 28, 2020

Uh oh!

kostmo commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

Detailed failure analysis

🚧 2 upstream failures recognized by patterns:

Uh oh!

yf225 commented Jan 29, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houseroad left a comment

Choose a reason for hiding this comment

Uh oh!

houseroad Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

neginraoof Jan 31, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

houseroad left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

neginraoof commented Jan 31, 2020

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 3, 2020

Uh oh!

tygrer commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kostmo commented Jan 28, 2020 •

edited

Loading

tygrer commented Mar 19, 2020 •

edited

Loading