[ROCm] Adjust elementwise_kernel settings on ROCm#32609
Closed
iotamudelta wants to merge 5 commits intopytorch:masterfrom
Closed
[ROCm] Adjust elementwise_kernel settings on ROCm#32609iotamudelta wants to merge 5 commits intopytorch:masterfrom
iotamudelta wants to merge 5 commits intopytorch:masterfrom
Conversation
Member
💊 CircleCI build failures summary and remediationsAs of commit d64e167:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakage:
|
ezyang
approved these changes
Jan 27, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
1 similar comment
Contributor
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Recent PR pytorch#31974 and upcoming PR pytorch#32383 are changing the behavior of the elementwise_kernel infrastructure on CUDA. In order to stay in sync, change the nd-loop behavior to match ROCm and CUDA for now. Once the full rework is done, the ROCm settings will likely diverge again. Pull Request resolved: pytorch#32609 Differential Revision: D19580121 Pulled By: ezyang fbshipit-source-id: 4c8dcf6db3ac973e48ece6a665615cfe7d7cb764
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Recent PR pytorch#31974 and upcoming PR pytorch#32383 are changing the behavior of the elementwise_kernel infrastructure on CUDA. In order to stay in sync, change the nd-loop behavior to match ROCm and CUDA for now. Once the full rework is done, the ROCm settings will likely diverge again. Pull Request resolved: pytorch#32609 Differential Revision: D19580121 Pulled By: ezyang fbshipit-source-id: 4c8dcf6db3ac973e48ece6a665615cfe7d7cb764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent PR #31974 and upcoming PR #32383 are changing the behavior of the elementwise_kernel infrastructure on CUDA.
In order to stay in sync, change the nd-loop behavior to match ROCm and CUDA for now. Once the full rework is done, the ROCm settings will likely diverge again.