[ONNX] Update support of exporting bool type index mask#32445
Closed
BowenBao wants to merge 2 commits intopytorch:masterfrom
Closed
[ONNX] Update support of exporting bool type index mask#32445BowenBao wants to merge 2 commits intopytorch:masterfrom
BowenBao wants to merge 2 commits intopytorch:masterfrom
Conversation
Member
💊 CircleCI build failures summary and remediationsAs of commit e115835:
Detailed failure analysisOne may explore the probable reasons each build failed interactively on the Dr. CI website. 🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakage:
|
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
LGTM! Thanks. |
lara-hdr
approved these changes
Jan 31, 2020
houseroad
approved these changes
Feb 3, 2020
|
|
||
| def try_mask_to_index(index): | ||
| if not sym_help._is_none(index) and index.type().scalarType() == "Byte": | ||
| if not sym_help._is_none(index) and (index.type().scalarType() == "Byte" or index.type().scalarType() == "Bool"): |
Member
There was a problem hiding this comment.
nit: create a helper function is_mask_type()
Contributor
|
@houseroad merged this pull request in 1c42b94. |
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: e.g. `tensor[torch.tensor([0, 1, 0], dtype=torch.bool)]` Previously the mask is of type uint8. Both uint8 and bool should be supported for export. Pull Request resolved: pytorch#32445 Reviewed By: hl475 Differential Revision: D19610713 Pulled By: houseroad fbshipit-source-id: 8df636e0c3cb0b82919a689242a962c79220209c
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: e.g. `tensor[torch.tensor([0, 1, 0], dtype=torch.bool)]` Previously the mask is of type uint8. Both uint8 and bool should be supported for export. Pull Request resolved: pytorch#32445 Reviewed By: hl475 Differential Revision: D19610713 Pulled By: houseroad fbshipit-source-id: 8df636e0c3cb0b82919a689242a962c79220209c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.
tensor[torch.tensor([0, 1, 0], dtype=torch.bool)]Previously the mask is of type uint8. Both uint8 and bool should be supported for export.