Skip to content

Update all instances of 1.4.0 -> 1.5.0#31785

Closed
seemethere wants to merge 1 commit intopytorch:masterfrom
seemethere:bump_150
Closed

Update all instances of 1.4.0 -> 1.5.0#31785
seemethere wants to merge 1 commit intopytorch:masterfrom
seemethere:bump_150

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jan 2, 2020

Done with:

❯ sed -i 's/1\.4\.0/1.5.0/g' $(find -type f -not -path "./third_party/*")

This was previously done in separate commits, but it would be beneficial to bump all included projects within this repository at the same time.

Old bumps for reference:

Signed-off-by: Eli Uriegas eliuriegas@fb.com

@seemethere seemethere requested a review from ezyang January 2, 2020 18:16
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@kostmo
Copy link
Member

kostmo commented Jan 2, 2020

💊 CircleCI build failures summary and remediations

As of commit 100fb6d:

None of the build failures appear to be your fault.

  • 2/2 broken upstream at merge base 9e9bfbf since Jan 02

    You may want to rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🚧 2 upstream failures recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@xta0
Copy link
Contributor

xta0 commented Jan 2, 2020

@seemethere what is this for? I thought the next version should be 1.4.0. am i missing anything here?

@seemethere
Copy link
Member Author

I believe @ezyang had mentioned that we should update these to 1.5.0

Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of duplicated version numbers in the ios packaging, @xta0 it would be good to figure out how to reduce this number as much as possible

@xta0
Copy link
Contributor

xta0 commented Jan 3, 2020

There are a lot of duplicated version numbers in the ios packaging, @xta0 it would be good to figure out how to reduce this number as much as possible

@ezyang I think there is just one file in this PR that related to iOS. Where are the other duplicated version numbers?

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in 346a349.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in 346a349.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Done with:

```
❯ sed -i 's/1\.4\.0/1.5.0/g' $(find -type f -not -path "./third_party/*")
```

This was previously done in separate commits, but it would be beneficial to bump all included projects within this repository at the same time.

Old bumps for reference:
* [iOS]Update Cocoapods to 1.4.0: pytorch#30326
* [android] Change nightly builds version to 1.4.0-SNAPSHOT: pytorch#27381
* Roll master to 1.4.0: pytorch#27374

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Pull Request resolved: pytorch#31785

Differential Revision: D19277925

Pulled By: seemethere

fbshipit-source-id: f72ad082f0566004858c9374879f4b1bee169f9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants