Remove LeftRight from OperatorEntry and DispatchTable.#30328
Remove LeftRight from OperatorEntry and DispatchTable.#30328resistor wants to merge 1 commit intopytorch:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
this should also be changed to an array for the same concurrency concerns we had with the dispatch table. Maybe it actually makes sense to factor out the concept of a KernelTable (but up to you)
There was a problem hiding this comment.
Since this is not a lambda anymore, we can resolve the TODO and just inline doCallUnboxed here. Would make the code much easier. But doesn't necessarily have to happen in this PR.
There was a problem hiding this comment.
same here about inlining doCallUnboxedOnly.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
re-export of #30328 Differential Revision: [D18661518](https://our.internmc.facebook.com/intern/diff/D18661518/) [ghstack-poisoned]
re-export of #30328 Differential Revision: [D18661518](https://our.internmc.facebook.com/intern/diff/D18661518/) ghstack-source-id: 94447549 Pull Request resolved: #30333
…atchTable." re-export of #30328 Differential Revision: [D18661518](https://our.internmc.facebook.com/intern/diff/D18661518/) [ghstack-poisoned]
No description provided.