Skip to content

Add more defensive tests for undefined tensors.#29907

Closed
ezyang wants to merge 2 commits intogh/ezyang/544/basefrom
gh/ezyang/544/head
Closed

Add more defensive tests for undefined tensors.#29907
ezyang wants to merge 2 commits intogh/ezyang/544/basefrom
gh/ezyang/544/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 15, 2019 •
edited
Loading

Stack from ghstack:

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Add more defensive tests for undefined tensors.
b1b4868 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang requested a review from apaszke as a code owner November 15, 2019 16:59
This was referenced Nov 15, 2019
Closed
Closed
Closed
ezyang added a commit that referenced this pull request Nov 15, 2019
@ezyang
Add more defensive tests for undefined tensors.
9fef9e1 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: b313edf
Pull Request resolved: #29907
@ezyang ezyang requested a review from albanD November 15, 2019 17:00
@kostmo
Copy link
Member

kostmo commented Nov 15, 2019 •
edited
Loading

CircleCI build failures summary

As of commit cff6ec0:

  • 9/9 failures introduced in this PR
  • 0/9 recognized as flaky

Here are the reasons each build failed:

Job Step Log excerpt
pytorch_linux_xenial_py2_7_9_build Build /var/lib/jenkins/workspace/c10/util/Exception.h:148:83: error:
caffe2_onnx_py2_gcc5_ubuntu16_04_test Test core dumped
caffe2_onnx_py3_6_clang7_ubuntu16_04_test Test core dumped
pytorch_linux_xenial_cuda9_cudnn7_py3_slow_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:
pytorch_linux_xenial_cuda9_cudnn7_py3_nogpu_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:
pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX2_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:
pytorch_linux_xenial_cuda9_cudnn7_py3_NO_AVX_NO_AVX2_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:
pytorch_linux_xenial_cuda9_cudnn7_py3_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:
pytorch_linux_xenial_py3_6_gcc5_4_test Test main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error:

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 13 time(s).

albanD
albanD approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@ezyang
Update on "Add more defensive tests for undefined tensors."
cff6ec0 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 18, 2019
@ezyang
Add more defensive tests for undefined tensors.
a279b48 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ghstack-source-id: 44064df
Pull Request resolved: #29907
@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2019

I'm merging this into the previous commit

@ezyang ezyang closed this Nov 20, 2019
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/544/head branch December 21, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @kostmo @albanD