Closed
Conversation
- Show values in question like glog. - Handle expressions with logical operators properly by adding parentheses around expressions.
Contributor
Author
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ljk53 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
BowenBao
pushed a commit
to BowenBao/pytorch
that referenced
this pull request
Feb 12, 2020
Summary: - Show values in question like glog. - Handle expressions with logical operators properly by adding parentheses around expressions. - Allow outputting nullptr (some build failed without this) Pull Request resolved: pytorch#29539 Reviewed By: dreiss Differential Revision: D19698991 Pulled By: ljk53 fbshipit-source-id: e329c01622cfc386ac009904092519a4adfe94a8
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: - Show values in question like glog. - Handle expressions with logical operators properly by adding parentheses around expressions. - Allow outputting nullptr (some build failed without this) Pull Request resolved: pytorch#29539 Reviewed By: dreiss Differential Revision: D19698991 Pulled By: ljk53 fbshipit-source-id: e329c01622cfc386ac009904092519a4adfe94a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parentheses around expressions.