Skip to content

Add missing default_collate in dataloader.pyi#28935

Closed
bryant1410 wants to merge 1 commit intopytorch:masterfrom
bryant1410:patch-4
Closed

Add missing default_collate in dataloader.pyi#28935
bryant1410 wants to merge 1 commit intopytorch:masterfrom
bryant1410:patch-4

Conversation

@bryant1410
Copy link
Contributor

No description provided.

@bryant1410 bryant1410 requested a review from apaszke as a code owner October 30, 2019 23:15
@ssnl
Copy link
Collaborator

ssnl commented Oct 31, 2019

default_collate is not meant to be part of the public API. Maybe we should not add annotation to it?

@bryant1410
Copy link
Contributor Author

bryant1410 commented Oct 31, 2019

But it is now. Maybe remove it when it's not anymore?

Also, why it's not part? I find it useful to call it from my own collate function.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 6996f8d.

BowenBao pushed a commit to BowenBao/pytorch that referenced this pull request Feb 12, 2020
Summary: Pull Request resolved: pytorch#28935

Differential Revision: D19698781

Pulled By: ezyang

fbshipit-source-id: abdd735c98656ed16cd326529441d1fcec2ace3e
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
Summary: Pull Request resolved: pytorch#28935

Differential Revision: D19698781

Pulled By: ezyang

fbshipit-source-id: abdd735c98656ed16cd326529441d1fcec2ace3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants